AW: [PATCH] drvmgr: Fix determination of prefix in grlib uart driver

Jan.Sommer at dlr.de Jan.Sommer at dlr.de
Thu Feb 20 08:40:57 UTC 2020


Hello,

Could someone please push this change?
There has been a lot of activity on this list recently, and I fear I will lose track at some point.

Cheers,

   Jan

> -----Ursprüngliche Nachricht-----
> Von: devel [mailto:devel-bounces at rtems.org] Im Auftrag von Jan Sommer
> Gesendet: Mittwoch, 12. Februar 2020 15:10
> An: devel at rtems.org
> Betreff: [PATCH] drvmgr: Fix determination of prefix in grlib uart driver
> 
> From: Dennis Pfau <dennis.pfau at dlr.de>
> 
> drvmgr_get_dev_prefix returns 0 if a prefix was found.
> Therefore the if condition needs to check for 0, i.e. DRVMGR_OK.
> ---
>  bsps/shared/grlib/uart/apbuart_cons.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/bsps/shared/grlib/uart/apbuart_cons.c
> b/bsps/shared/grlib/uart/apbuart_cons.c
> index ee635e6944..e4d026a4cc 100644
> --- a/bsps/shared/grlib/uart/apbuart_cons.c
> +++ b/bsps/shared/grlib/uart/apbuart_cons.c
> @@ -321,7 +321,7 @@ int apbuart_init1(struct drvmgr_dev *dev)
>  	priv->condev.fsname = NULL;
>  	/* Get Filesystem name prefix */
>  	prefix[0] = '\0';
> -	if (drvmgr_get_dev_prefix(dev, prefix)) {
> +	if (drvmgr_get_dev_prefix(dev, prefix) == DRVMGR_OK) {
>  		/* Got special prefix, this means we have a bus prefix
>  		 * And we should use our "bus minor"
>  		 */
> --
> 2.17.1
> 
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel


More information about the devel mailing list