[PATCH] cpukit/libfs: remove dead code from pipe/fifo.c

Joel Sherrill joel at rtems.org
Fri Jan 3 18:54:51 UTC 2020


This looks ok to me.

On Fri, Jan 3, 2020, 12:51 PM Gedare Bloom <gedare at rtems.org> wrote:

> Dead code identified by Coverity (CID 1456678). The value of ret
> at line 293 is always 0.
> ---
>  cpukit/libfs/src/pipe/fifo.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/cpukit/libfs/src/pipe/fifo.c b/cpukit/libfs/src/pipe/fifo.c
> index b64c0d95b6..579f118bfd 100644
> --- a/cpukit/libfs/src/pipe/fifo.c
> +++ b/cpukit/libfs/src/pipe/fifo.c
> @@ -290,8 +290,6 @@ ssize_t pipe_read(
>      pipe->waitingReaders ++;
>      PIPE_READWAIT(pipe);
>      pipe->waitingReaders --;
> -    if (ret != 0)
> -      goto out_locked;
>    }
>
>    /* Read chunk bytes */
> --
> 2.17.1
>
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20200103/9845cbe3/attachment.html>


More information about the devel mailing list