[PATCH 05/33] libtest: Add T_make_runner()

[Sebastian Huber]

On 22/07/2020 07:04, Chris Johns wrote:

> On 22/7/20 1:04 am, Sebastian Huber wrote:
>> Update #3199.
>> ---
>>   cpukit/include/rtems/test.h |  2 ++
>>   cpukit/libtest/t-test.c     | 10 ++++++++--
>>   2 files changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/cpukit/include/rtems/test.h b/cpukit/include/rtems/test.h
>> index b68f303e16..a1a976d7ff 100644
>> --- a/cpukit/include/rtems/test.h
>> +++ b/cpukit/include/rtems/test.h
>> @@ -2209,6 +2209,8 @@ void T_putchar_default(int, void *);
>>   
>>   int T_main(const T_config *);
>>   
>> +void T_make_runner(void);
>> +
>>   bool T_is_runner(void);
>>   
>>   void T_run_initialize(const T_config *);
>> diff --git a/cpukit/libtest/t-test.c b/cpukit/libtest/t-test.c
>> index 16018335c9..a0336fa461 100644
>> --- a/cpukit/libtest/t-test.c
>> +++ b/cpukit/libtest/t-test.c
>> @@ -330,7 +330,7 @@ T_scope(char *buf)
>>   }
>>   
>>   static void
>> -T_set_runner(T_context *ctx)
>> +T_do_make_runner(T_context *ctx)
>>   {
>>   #ifdef __rtems__
>>   	ISR_Level level;
> Indenting 4 or 2 spaces?
>
>> @@ -353,6 +353,12 @@ T_set_runner(T_context *ctx)
>>   #endif
>>   }
>>   
>> +void
>> +T_make_runner(void)
>> +{
>> +	T_do_make_runner(&T_instance);
>> +}
>> +
>>   int
>>   T_printf(char const *fmt, ...)
>>   {
>> @@ -719,7 +725,7 @@ T_do_run_initialize(const T_config *config)
>>   	ctx->overall_steps = 0;
>>   	ctx->overall_failures = 0;
>>   
>> -	T_set_runner(ctx);
>> +	T_do_make_runner(ctx);
>>   	T_actions_forward(config, T_EVENT_RUN_INITIALIZE_EARLY, config->name);
>>   	T_do_log(ctx, T_QUIET, "A:%s\n", config->name);
>>   	T_system(ctx);
> Same here?
>
> This comment is also for all the remaining files in touched by the patches. I
> see a mix.
The test framework uses the BSD coding style. The core implementation is 
done in C11 and is portable to FreeBSD, MSYS2, and Linux. The 
indentation level is one tab.