Strong APA Scheduler : First Draft

Gedare Bloom gedare at rtems.org
Tue Jul 28 03:38:07 UTC 2020


On Mon, Jul 27, 2020 at 7:11 AM Richi Dubey <richidubey at gmail.com> wrote:
>
> Dear Dr. Bloom,
>
> Please find the pull request of my branch with my repo's master at https://github.com/richidubey/rtems/pull/3. All the compiler errors and warnings have been removed, but the implementation would not work because there are some places with no code (backtracking). It'd be great if you can point out any wrong logic/code.
>

Please double-check your pull request. Something looks wrong. It just
has a template of a testsuite directory.

> Thanks.
> Richi.
>
>
>
> On Mon, Jul 27, 2020 at 1:14 PM Richi Dubey <richidubey at gmail.com> wrote:
>>>
>>> Which compiler error do you get? Maybe there is a cyclic dependency.
>>
>>
>> I assumed that the schedulersmp.h already includes the percpu.h which was not the case. My bad. The error has been removed.
>>
>> I assumed this because schedulersmp.h uses Per_CPU_Control and does not show any compilation error, so it should have the percpu.h included in one of its included header files right? If it has, why did my schedulerstrongapa.h that had the schedulersmp.h included give the following error:
>>
>> /home/richi/quick-start/src/rtems/cpukit/include/rtems/score/schedulerstrongapa.h:102:3: error: unknown type name 'Per_CPU_Control'
>>    Per_CPU_Control cpu;
>>
>> On Mon, Jul 27, 2020 at 10:30 AM Sebastian Huber <sebastian.huber at embedded-brains.de> wrote:
>>>
>>> On 26/07/2020 16:03, Gedare Bloom wrote:
>>>
>>> > On Sat, Jul 25, 2020 at 11:21 AM Richi Dubey<richidubey at gmail.com>  wrote:
>>> >> Dear Dr. Bloom,
>>> >>
>>> >> Please find the pull request at the following link:https://github.com/RTEMS/rtems/pull/39.
>>> >>
>>> > It would be great if you can create a GitHub Pull Request (PR) for
>>> > your branch against your "master" branch in your fork.
>>> >
>>> > I'd prefer you not submit a PR to RTEMS repo, but rather, to your
>>> > forked repo. We don't review PRs on RTEMS/github in general, so it is
>>> > better to keep this review off the github mirror.
>>> Yes, this would be nice.
>>> >> Please note that I have tried to remove all the compilation errors but this still won't compile right now, because my implementation requires the use of percpu.h file, which (I'm assuming) is not currently linked with the source files related to Strong APA.
>>> >>
>>> > That seems strange.
>>> >
>>> Which compiler error do you get? Maybe there is a cyclic dependency.
>>>


More information about the devel mailing list