[PATCH 1/2] Convert host checking to pytest.

Chris Johns chrisj at rtems.org
Mon Mar 16 00:48:07 UTC 2020


On 16/3/20 11:02 am, Amar Takhar wrote:
> On 2020-03-16 09:30 +1100, Chris Johns wrote:
>> Hi,
>>
>> This looks good. Thank you for making the switch to pytest.
>>
>> Are you planning on moving all the exist "chris hacked" tests to pytest?
> 
> I don't know probably not I don't have the time this was to get someone started.

That is understandable. Are the patches available in your personal repo?

>> If so I am wondering how you will stage the change? This size patch is perfect
>> but I am concerned we may have some done and others not when the release branch
>> is made if we push them in pieces?
> 
> I don't see that as a problem personally this is why I added the message.

I am fine with pieces being pushed after RTEMS 5 has branched. My concern is
only related to the pending release. It is only a couple of weeks away if that.

> The pytests are more comprehensive even if they don't all get converted going 
> forward we should be using pytest and anyone wishing to contribute can convert 
> them.

I agree and starting this happening is a great contribution. Thank you.

> I've done 4 examples that should cover all our use cases for the rest of the 
> code.  Converting the rest is pretty easy and I'm available to help anyone who 
> has difficulty.

Yes and again thank you.

Chris


More information about the devel mailing list