[PATCH v1 01/16] Py2/3 compliant tools/gdb/python

[Anmol Mishra]

Hello,
I can understand your requests, I also thought to squash/combine all
changes in 1 patch. I will complete the task in a day and resend the patch.
I did not know the protocol/contributing guide. I will keep a note of this.
Sorry for the trouble.

Regards

On Thu, Mar 19, 2020 at 9:53 PM Gedare Bloom <gedare at rtems.org> wrote:

> Hi Anmol,
>
> Thanks for your patches. I have a few requests.
>
> Can you please provide some details in your commit message? In
> particular, since few of us right now know how to make code compliant
> between Python 2 and 3, can you provide a brief
> justification/description for what the changes are and how they
> address this problem?
>
> In general you can send your first set of patches without a -v1. That
> is implied.
>
> When you send a lot of patches it is good if you also prepare a
> git-cover-letter (patch 00/xx) to explain the patch set.
>
> Instead of going file-by-file with patches, you might also consider
> organizing patches by addressing "kinds" of compliance fixes. For
> example, a single patch could sweep up a bunch of "from __future__
> import ..." across several files. Either way is really OK, patches
> that touch just one file are less likely to conflict, but a patch that
> does one thing across many files is easier to review/approve. I'll
> leave it up to you how you want to proceed.
>
>
>
> On Wed, Mar 18, 2020 at 6:19 AM Anmol mishra <anmol.j2020 at gmail.com>
> wrote:
> >
> > From: Anmol Mishra <anmol.j2020 at gmail.com>
> >
> > ---
> >  tools/gdb/python/__init__.py | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/tools/gdb/python/__init__.py b/tools/gdb/python/__init__.py
> > index 0ea5fb2..dfbe6ba 100644
> > --- a/tools/gdb/python/__init__.py
> > +++ b/tools/gdb/python/__init__.py
> > @@ -27,8 +27,11 @@
> >  # POSSIBILITY OF SUCH DAMAGE.
> >  #
> >
> > +from __future__ import print_function
> > +from __future__ import absolute_import
> > +
> >  import gdb
> > -import rtems
> > +from . import rtems
> >
> >  def get_architure():
> >      frame = gdb.selected_frame()
> > --
> > 2.21.0 (Apple Git-122.2)
> >
> > _______________________________________________
> > devel mailing list
> > devel at rtems.org
> > http://lists.rtems.org/mailman/listinfo/devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20200320/b9a74ffa/attachment.html>