[PATCH v7] tests for fenv.h functions

[Aditya Upadhyay]

On Sat, Mar 21, 2020 at 9:32 PM Eshan Dhawan <eshandhawan51 at gmail.com> wrote:
>
> I have added the changes as told by Aditya
> I would like to know is any other changes are required to be made to make the patch usable
>
> Thanks
> Eshan
> > On 21-Mar-2020, at 8:20 PM, Eshan dhawan <eshandhawan51 at gmail.com> wrote:
> >
> > ---
> > testsuites/psxtests/psxfenv01/init.c | 89 ++++++++++++++++++++++------
> > 1 file changed, 71 insertions(+), 18 deletions(-)
> >
> > diff --git a/testsuites/psxtests/psxfenv01/init.c b/testsuites/psxtests/psxfenv01/init.c
> > index cdb0fa596e..0ea820c523 100644
> > --- a/testsuites/psxtests/psxfenv01/init.c
> > +++ b/testsuites/psxtests/psxfenv01/init.c
> > @@ -46,11 +46,12 @@
> > #include <string.h>
> > #include <rtems/test.h>
> > #include <tmacros.h>
> > +#include <float.h>
> >
> > const char rtems_test_name[] ="PSXFENV 01";
> >
> > /* forward declarations to avoid warnings */
> > -rtems_task Init(rtems_task_argument ignored);
> > +rtems_task Init( rtems_task_argument ignored );
> >
> > /* Test Function Begins */
> > rtems_task Init(rtems_task_argument ignored)
> > @@ -62,28 +63,31 @@ rtems_task Init(rtems_task_argument ignored)
> >
> >  /*
> >   * 'FE_ALL_EXCEPT' will be defined only when 'feclearexcept()',
> > -   * 'fegetexceptflag()', 'feraiseexcept()', 'fesetexceptflag()' and
> > -   * 'fetestexcept()' functions are supported by the architecture.
> > +   * fegetexceptflag() , feraiseexcept(), fesetexceptflag() and
> > +   * fetestexcept() functions are supported by the architecture.
> >   * Hence their testcases can be wrapped under #ifdef and #endif.
> >   */
> >  #ifdef FE_ALL_EXCEPT /* floating-point exceptions */
> >    puts( "fesetenv(FE_DFL_ENV)." );
> > -    r = fesetenv(FE_DFL_ENV);
> > -    if (r)
> > +    r = fesetenv ( FE_DFL_ENV );

It should be like r = fesetenv( FE_DFL_ENV).

> > +    if ( r ) {
> >      printf("fesetenv ==> %d\n", r);

After (, one space needed.
> > -    rtems_test_assert( r == 0 );
> > +    }
> > +    rtems_test_assert ( r == 0 );

Same here, Remove this unnecessary space, assert and (.

> >
> > -    /* Test 'feclearexcept()' and 'fetestexcept()' in one go. */
> > -    puts( "feclearexcept(FE_ALL_EXCEPT)." );
> > -    r = feclearexcept(FE_ALL_EXCEPT);
> > -    if (r)
> > +    /* Test feclearexcept() and fetestexcept() in one go. */
> > +    puts( "feclearexcept(FE_ALL_EXCEPT)" );
> > +    r = feclearexcept ( FE_ALL_EXCEPT );
> > +    if ( r ) {
> >      printf("feclearexcept ==> 0x%x\n", r);
> > -    rtems_test_assert( r == 0 );
> > +    }
> > +    rtems_test_assert ( r == 0 );
> >
Same here.

> > -    r = fetestexcept( FE_ALL_EXCEPT );
> > -    if (r)
> > +    r = fetestexcept ( FE_ALL_EXCEPT );
> > +    if ( r ) {
> >      printf("fetestexcept ==> 0x%x\n", r);
> > -    rtems_test_assert( r == 0 );
> > +    }
> > +    rtems_test_assert ( r == 0 );
> >
> >    /* Test 'FE_DIVBYZERO' */
> >    puts( "Divide by zero and confirm fetestexcept()" );
> > @@ -91,11 +95,60 @@ rtems_task Init(rtems_task_argument ignored)
> >    b = 1.0;
> >    c = b/a;
> >    (void) c;
> > -
> > -    fegetexceptflag(&excepts,FE_ALL_EXCEPT);
> > -
> > +    /* Test fegetexceptflag() and fesetexceptflag() */
> > +    r = fegetexceptflag ( &excepts, FE_ALL_EXCEPT );
> > +    if ( r ) {
> > +      printf("fegetexceptflag ==> 0x%x\n", r);
> > +    }
> > +    rtems_test_assert ( r == 0 );
> > +
> > +    r = fesetexceptflag ( &excepts, FE_ALL_EXCEPT );
> > +    if ( r ) {
> > +      printf("fesetexceptflag ==> 0x%x\n", r);
> > +    }
> > +    rtems_test_assert ( r == 0 );
> > +
> > +    /* Test for fegetround() and fesetround()
> > +     * They have four main macros to be tested separated by ifdef
> > +     * Since not all architectures support them
> > +     * The test case gets and sets the rounding directions */
> > +#ifdef FE_TONEAREST
> > +    rtems_test_assert ( fegetround() == FE_TONEAREST );
> > +#endif
> > +#ifdef FE_TOWARDZERO
> > +  r = fesetround ( FE_TOWARDZERO );
> > +  if ( r ) {
> > +      printf("fesetround ==> 0x%x\n", r);
> > +    }
> > +  rtems_test_assert ( r == 0 );
> > +  rtems_test_assert ( fegetround() == FE_TOWARDZERO );
> > +#endif
> > +#ifdef FE_DOWNWARD
> > +  r = fesetround ( FE_DOWNWARD );
> > +  if ( r ) {
> > +      printf("fesetround ==> 0x%x\n", r);
> > +    }
> > +  rtems_test_assert ( r == 0 );
> > +  rtems_test_assert ( fegetround() == FE_DOWNWARD );
> > +#endif
> > +#ifdef FE_UPWARD
> > +  r = fesetround ( FE_UPWARD );
> > +  if ( r ) {
> > +      printf("fesetround ==> 0x%x\n", r);
> > +    }
> > +  rtems_test_assert ( r == 0 );
> > +  rtems_test_assert ( fegetround() == FE_UPWARD );
> > +#endif
> > +#ifdef FE_TONEAREST
> > +  r = fesetround ( FE_TONEAREST );
> > +  if ( r ) {
> > +      printf("fesetround ==> 0x%x\n", r);
> > +    }
> > +  rtems_test_assert ( r == 0 );
> > +#endif
> > +
> > #ifdef FE_DIVBYZERO
> > -    r = feraiseexcept(FE_DIVBYZERO);
> > +    r = feraiseexcept ( FE_DIVBYZERO ) ;
> >    rtems_test_assert( fetestexcept( FE_DIVBYZERO ) );
> > #endif
> >
> > --
> > 2.17.1

I would suggest you go through the existing test-cases within the
/rtems5/testsuites/psxtests directory. Use any of the .c files as a
reference.
Make the change accordingly.

Are you able to check the values of these variables that you have used
in this test?