[PATCH 1/2] bsp/raspberrypi: Fix build warnings.

Niteesh G. S. niteesh.gs at gmail.com
Sun Mar 29 04:32:18 UTC 2020


I have a sent v2. It uses PRIdrtems_vector_number as the specifier.
Please have a look at it.
https://lists.rtems.org/pipermail/devel/2020-March/058716.html

Thank you,
Niteesh

On Sun, Mar 29, 2020 at 5:17 AM Gedare Bloom <gedare at rtems.org> wrote:

> On Sat, Mar 28, 2020 at 10:11 AM Joel Sherrill <joel at rtems.org> wrote:
> >
> > This looks ok. UNLESS we have an RTEMS specific inttypes.h format
> specifier for vector.
> >
> > I don't recall where those are defined or documented. :(
> >
>
> Maybe we ought to, but this should never be an lu anyway.
>
> > On Sat, Mar 28, 2020, 5:50 AM G S Niteesh Babu <niteesh.gs at gmail.com>
> wrote:
> >>
> >> 1) _Memory_Initialize makes pointer from integer w
> >> ithout a cast.
> >> 2) printf format error, expects %u but %lu provided.
> >> ---
> >>  bsps/arm/raspberrypi/irq/irq.c             | 2 +-
> >>  bsps/arm/raspberrypi/start/bspstarthooks.c | 2 ++
> >>  2 files changed, 3 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/bsps/arm/raspberrypi/irq/irq.c
> b/bsps/arm/raspberrypi/irq/irq.c
> >> index 9e1bcfc1bc..73dcad298f 100644
> >> --- a/bsps/arm/raspberrypi/irq/irq.c
> >> +++ b/bsps/arm/raspberrypi/irq/irq.c
> >> @@ -157,7 +157,7 @@ void
> bsp_interrupt_vector_disable(rtems_vector_number vector)
> >>
> >>  void bsp_interrupt_handler_default(rtems_vector_number vector)
> >>  {
> >> -    printk("spurious interrupt: %lu\n", vector);
> >> +    printk("spurious interrupt: %u\n", vector);
> >>  }
> >>
> >>  rtems_status_code bsp_interrupt_facility_initialize(void)
> >> diff --git a/bsps/arm/raspberrypi/start/bspstarthooks.c
> b/bsps/arm/raspberrypi/start/bspstarthooks.c
> >> index fd6aa53059..eb6546db1c 100644
> >> --- a/bsps/arm/raspberrypi/start/bspstarthooks.c
> >> +++ b/bsps/arm/raspberrypi/start/bspstarthooks.c
> >> @@ -184,7 +184,9 @@ static void bsp_memory_initialize(void)
> >>  {
> >>    _Memory_Initialize(
> >>      &_Memory_Areas[0],
> >> +    (void *)
> >>
> raspberrypi_mmu_config_table[ARMV7_CP15_START_WORKSPACE_ENTRY_INDEX].begin,
> >> +    (void *)
> >>
> raspberrypi_mmu_config_table[ARMV7_CP15_START_WORKSPACE_ENTRY_INDEX].end
> >>    );
> >>  }
> >> --
> >> 2.17.1
> >>
> > _______________________________________________
> > devel mailing list
> > devel at rtems.org
> > http://lists.rtems.org/mailman/listinfo/devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20200329/78401228/attachment-0001.html>


More information about the devel mailing list