[PATCH v2 3/6] rtems: Move _Partition_Is_buffer_size_aligned()

Sebastian Huber sebastian.huber at embedded-brains.de
Mon Nov 23 10:35:42 UTC 2020


It is only used by rtems_partition_create().  Move code directly into
the directive which called the inline function.
---
 cpukit/include/rtems/rtems/partimpl.h | 7 -------
 cpukit/rtems/src/partcreate.c         | 7 ++++++-
 2 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/cpukit/include/rtems/rtems/partimpl.h b/cpukit/include/rtems/rtems/partimpl.h
index 0d15d1e991..b9d57ae3c3 100644
--- a/cpukit/include/rtems/rtems/partimpl.h
+++ b/cpukit/include/rtems/rtems/partimpl.h
@@ -34,13 +34,6 @@ extern "C" {
  * @{
  */
 
-RTEMS_INLINE_ROUTINE bool _Partition_Is_buffer_size_aligned(
-  uint32_t buffer_size
-)
-{
-  return (buffer_size % CPU_SIZEOF_POINTER) == 0;
-}
-
 RTEMS_INLINE_ROUTINE bool _Partition_Is_buffer_area_aligned(
   const void *starting_address
 )
diff --git a/cpukit/rtems/src/partcreate.c b/cpukit/rtems/src/partcreate.c
index 9d4c7df283..1e471d3c0a 100644
--- a/cpukit/rtems/src/partcreate.c
+++ b/cpukit/rtems/src/partcreate.c
@@ -58,8 +58,13 @@ rtems_status_code rtems_partition_create(
   if ( length < buffer_size )
     return RTEMS_INVALID_SIZE;
 
-  if ( !_Partition_Is_buffer_size_aligned( buffer_size ) )
+  /*
+   * Ensure that the buffer size is an integral multiple of the pointer size so
+   * that each buffer begin meets the chain node alignment.
+   */
+  if ( buffer_size % CPU_SIZEOF_POINTER != 0 ) {
     return RTEMS_INVALID_SIZE;
+  }
 
   if ( buffer_size < sizeof( Chain_Node ) )
     return RTEMS_INVALID_SIZE;
-- 
2.26.2



More information about the devel mailing list