[PATCH] testsuites/samples/fileio - Increase of stack size

[Joel Sherrill]

On Fri, Oct 9, 2020 at 9:11 AM Kinsey Moore <kinsey.moore at oarcorp.com>
wrote:

> I'm not sure it's specifically a GCC10 issue, but I've encountered
> something like this before (I think it was GCC8 or GCC9).
>
> https://github.com/ISI-apex/rtems/commit/edd6d90c3ad21393dd0de93056f371c7abc89b78
>
> I thought I'd sent in a patch for this or at least created a ticket, but I
> can't find either at the moment.
>

Would switching this BSP from -O0 to -Og be prudent also?

I assume it is using -O0 to ease debugging.

--joel

>
> Kinsey
>
> -----Original Message-----
> From: devel <devel-bounces at rtems.org> On Behalf Of Frank Kühndel
> Sent: Friday, October 9, 2020 09:06
> To: joel at rtems.org
> Cc: rtems-devel at rtems.org <devel at rtems.org>
> Subject: Re: [PATCH] testsuites/samples/fileio - Increase of stack size
>
> Hi Joel,
>
> Sebastian is the opinion its a "GCC 10 issue".
>
> On 10/9/20 3:32 PM, Joel Sherrill wrote:
> > This is interesting. When I teach RTEMS classes, I always run this
> > application and the last time, this BSP was the one used. It was a
> > rare case of all Zynq users with no LEON users. :)
> >
> > What version of RTEMS and how did you configure it?
>
> Version is the newest, I think 6:
>
> remote.origin.url=git://git.rtems.org/rtems.git
>
> The branch bases on origin/master.
> The preceding commit was:
> commit 558a19d3adff6a3ecf678f94408b48beccbbc9fb (origin/master,
> origin/HEAD, master)
>
> The config.ini is
>
> [arm/realview_pbx_a9_qemu]
> RTEMS_DEBUG = True
> RTEMS_NETWORKING = True
> RTEMS_POSIX_API = True
> RTEMS_SMP = True
> BUILD_TESTS = True
>
> >
> > This sounds like it may need a ticket since it likely needs to be
> > included on the 5 branch.pa <http://branch.pa>
>
> I can open a ticket for 5 and 6 if you like.
>
> Greetings
> Frank
>
> >
> > I don't doubt it crashed. Just want details so we can apply the patch
> > properly.
> >
> > --joel
> >
> > On Fri, Oct 9, 2020 at 8:07 AM Frank Kuehndel
> > <frank.kuehndel at embedded-brains.de
> > <mailto:frank.kuehndel at embedded-brains.de>> wrote:
> >
> >     When I use the 'shell' from the fileio sample with the command below:
> >
> >        env QEMU_AUDIO_DRV="none" \
> >        qemu-system-arm -no-reboot -net none -nographic -M
> >     realview-pbx-a9 -m 256M \
> >        -kernel
> > build/arm/realview_pbx_a9_qemu/testsuites/samples/fileio.exe
> >
> >     The executable crashes with an "BLOWN STACK!!!" as soon as I try to
> >     login
> >     as 'root' with password. (The logins without password work fine.)
> >     Increasing
> >     the stack size of the affected thread a bit solves the issue. Hence,
> >     I suggest this patch.
> >     ---
> >      testsuites/samples/fileio/init.c | 2 +-
> >      1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >     diff --git a/testsuites/samples/fileio/init.c
> >     b/testsuites/samples/fileio/init.c
> >     index 86b34b99dd..c552d33613 100644
> >     --- a/testsuites/samples/fileio/init.c
> >     +++ b/testsuites/samples/fileio/init.c
> >     @@ -630,7 +630,7 @@ static void fileio_start_shell(void)
> >        printf(" =========================\n");
> >        rtems_shell_init(
> >          "SHLL",                          /* task_name */
> >     -    RTEMS_MINIMUM_STACK_SIZE * 4,    /* task_stacksize */
> >     +    RTEMS_MINIMUM_STACK_SIZE * 5,    /* task_stacksize */
> >          100,                             /* task_priority */
> >          "/dev/foobar",                   /* devname */
> >          /* device is currently ignored by the shell if it is not a pty
> */
> >     --
> >     2.26.2
> >
> >     _______________________________________________
> >     devel mailing list
> >     devel at rtems.org <mailto:devel at rtems.org>
> >     http://lists.rtems.org/mailman/listinfo/devel
> >
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20201009/ffd3d348/attachment-0001.html>