[rtems commit] rtems-fdt / shell - Fix string truncation warning

Sebastian Huber sebastian.huber at embedded-brains.de
Fri Oct 16 04:28:53 UTC 2020

On 16/10/2020 01:36, Chris Johns wrote:
> On 16/10/20 4:23 am, Sebastian Huber wrote:
>> rtems-fdt.c, rtems-fdt-shell.c and cpukit/include/rtems/rtems-fdt.h
>> seem to be dead code. They implement a shell command `fdt` but that
>> command is not part of the shell nor of any macro in
>> cpukit/include/rtems/shellconfig.h.
> This comment is wrong and should not have been in the commit message and should
> _not_ have been pushed. As I stated in my review it could be simple issue of not
> being in the config file and documentation. I feel EB needs to be more
> restrained in its view of what is used and not used in RTEMS and someone new the
> community might be advised to take a simple approach with wording when posting
> patches.

The code in question

* had warnings,

* is not integrated in the shell configuration,

* has no tests,

* no documentation, and

* is in the architecture-independent area,

so a comment that says this seems to be dead code is justified from my 
point of view.

> Please revert the change and then wait for the process to complete on the devel
> mailing list to complete. I will ack the patches when _I_ am OK with them.

Yes, sorry, the review time was too short.

Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.

More information about the devel mailing list