set_vector() on SPARC

[Joel Sherrill]

On Thu, Oct 15, 2020 at 11:40 PM Chris Johns <chrisj at rtems.org> wrote:

> On 16/10/20 3:30 pm, Sebastian Huber wrote:
> > On 16/10/2020 03:09, Chris Johns wrote:
> >> On 16/10/20 4:57 am, Sebastian Huber wrote:
> >>> I suggest to remove this function and replace it with
> rtems_interrupt_catch()
> >>> and add the interrupt enable to rtems_interrupt_catch().
> >> Which BSPs will this effect?
> >
> > All SPARC BSPs.
>
> OK.
>

Unless you make that all BSPs which have set_vector, I am not in favor of
this.

set_vector() was intended many many years ago as a central place for a BSP
to touch an interrupt mask register if it had one. This was sometimes
present
on architectures which we now call simple vectored. This was universally
present across all simple vectored architectures.

If you want to eliminate it, do so. Don't leave it partially present.

>
> >> What testing on real hardware will there be?
> >
> > I will test on GR712RC and GR740. I hope Gaisler tests the RTEMS master
> from
> > time to time on their hardware.
>
> Yes. Testing as we are working on changes is much more helpful than
> finding out
> long after the focus has shifted.
>

+1

>
> Thanks
> Chris
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20201016/b619941e/attachment.html>