[PATCH 1/2] build: Report caching errors

Chris Johns chrisj at rtems.org
Wed Oct 28 05:52:23 UTC 2020


Both patches look good.

Thanks
Chris

On 28/10/20 4:37 pm, Sebastian Huber wrote:
> The ctx.fatal() method uses an exception to stop the build.  Do not
> catch it.
> ---
>  wscript | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/wscript b/wscript
> index ce71efc488..432d705107 100755
> --- a/wscript
> +++ b/wscript
> @@ -1109,9 +1109,9 @@ def is_one_item_newer(ctx, path, mtime):
>  def must_update_item_cache(ctx, path, cache_file):
>      try:
>          mtime = os.path.getmtime(cache_file)
> -        return is_one_item_newer(ctx, path, mtime)
>      except:
>          return True
> +    return is_one_item_newer(ctx, path, mtime)
>  
>  
>  def load_from_yaml(load, ctx, data_by_uid, base, path):
> 


More information about the devel mailing list