[PATCH 1/4] main_cp.c: Unused value (CID #1255344)

[Joel Sherrill]

On Tue, Apr 6, 2021 at 3:28 PM Chris Johns <chrisj at rtems.org> wrote:

>
> > On 6 Apr 2021, at 5:38 am, Ryan Long <ryan.long at oarcorp.com> wrote:
> >
> > CID 1255344: Unused value in copy().
> >
> > Closes #4339
> > ---
> > cpukit/libmisc/shell/main_cp.c | 64
> ++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 64 insertions(+)
> >
> > diff --git a/cpukit/libmisc/shell/main_cp.c
> b/cpukit/libmisc/shell/main_cp.c
> > index cddbc95..2984a50 100644
> > --- a/cpukit/libmisc/shell/main_cp.c
> > +++ b/cpukit/libmisc/shell/main_cp.c
> > @@ -310,11 +310,31 @@ copy(rtems_shell_cp_globals* cp_globals,
> >        case FTS_ERR:
> >            warnx("%s: %s",
> >                curr->fts_path, strerror(curr->fts_errno));
> > +        #if __rtems__
>
> Is this ok or should it be #ifdef?
>

Style preference. Your choice. What's the libbsd rule?

-DVAR gets 1 but "#define VAR" is empty.

__rtems__ is 1 on RTEMS toolsets

I think I just told Ryan the wrong thing privately.

>
> Chris
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20210406/e4fca27c/attachment.html>