[PATCH 1/4] main_cp.c: Unused value (CID #1255344)

Chris Johns chrisj at rtems.org
Tue Apr 6 22:43:49 UTC 2021

On 7/4/21 6:36 am, Ryan Long wrote:
> Oh, I definitely missed that. I'm not sure though, but other patches have used #ifdef.  So I should only resubmit this patch then?

No. Please submit the whole patch set with a new patch set version number.

And this is what needs to happen from now on. Splitting patches into ACKed and
NACKed sets and then incrementally submitting them in smaller groups until done
combined with fragments of sets being pushed is unhelpful to reviewers and in
the end it is not a great way to have patches accepted.

If I see a patch set is needs more work I will move on rather than examining
what is there in detail as things may change. This means patches in the set that
have no comments may end up with comments in further reviews.


More information about the devel mailing list