[PATCH 2/2] main_rtrace.c: Fix Dereference after null check (CID #1399709)

[Joel Sherrill]

I'll pick on you. :)

Please don't use the "title" that says "Fix ABC". There has to be a better
description.

Hopefully someone will ack the technical. I think it is right.

--joel

On Wed, Apr 14, 2021 at 9:20 AM Ryan Long <ryan.long at oarcorp.com> wrote:

> ping
>
> -----Original Message-----
> From: Ryan Long <ryan.long at oarcorp.com>
> Sent: Friday, March 12, 2021 8:56 AM
> To: devel at rtems.org
> Cc: Ryan Long <ryan.long at oarcorp.com>
> Subject: [PATCH 2/2] main_rtrace.c: Fix Dereference after null check (CID
> #1399709)
>
> CID 1399709: Dereference after null check in
> rtems_trace_buffering_shell_save().
>
> Closes #4329
> ---
>  cpukit/libmisc/shell/main_rtrace.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/cpukit/libmisc/shell/main_rtrace.c
> b/cpukit/libmisc/shell/main_rtrace.c
> index 753ab9d..e4f59c4 100644
> --- a/cpukit/libmisc/shell/main_rtrace.c
> +++ b/cpukit/libmisc/shell/main_rtrace.c
> @@ -473,6 +473,7 @@ rtems_trace_buffering_shell_save (int argc, char
> *argv[])
>    {
>      close (out);
>      printf ("error: no memory\n");
> +    return 1;
>    }
>
>    memset (buf, 0, SAVE_BUF_SIZE);
> --
> 1.8.3.1
>
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20210414/09c9c13c/attachment-0001.html>