[PATCH v1 0/5] Fix ostream format errors

Ryan Long ryan.long at oarcorp.com
Wed Aug 4 15:54:19 UTC 2021


Hi,

The last "Restore ostream format" patch set didn't fix the Coverity issues.
We verified that resetiosflags() will get rid of the issues complaints about
std::left and std::right changing the stream's format, I noticed that it
didn't complain if std::setfill(' ') was used after changing the setfill value
to something else.

I don't know if Coverity will recognize storing the precision value and
restoring it as a fix for the setprecision() calls, but the only other
option is to just set the precision value to 6 (the default value).

Thanks,
Ryan

Ryan Long (5):
  rtems-utils.h: Remove ostream_guard
  rtems-exeinfo.cpp: Reset cout stream flags
  CoverageMapBase.cc: Restore ostream format
  ReportsHtml.cc: Restore ostream format
  ReportsText.cc: Restore ostream format

 linkers/rtems-exeinfo.cpp        | 11 ++++-------
 rtemstoolkit/rtems-utils.h       | 20 --------------------
 tester/covoar/CoverageMapBase.cc |  6 +-----
 tester/covoar/ReportsHtml.cc     | 11 +++++------
 tester/covoar/ReportsText.cc     | 12 +++++-------
 5 files changed, 15 insertions(+), 45 deletions(-)

-- 
1.8.3.1



More information about the devel mailing list