[PATCH rtems-libbsd v2 5/5] create-kernel-namespace for USB Template driver

[Chris Johns]

On 2/8/21 4:24 am, Ahamed Husni wrote:
> Hello Chris,
> 
> On Thu, Jul 29, 2021 at 5:41 AM Chris Johns <chrisj at rtems.org
> <mailto:chrisj at rtems.org>> wrote:
> 
>     On 28/7/21 9:56 pm, Husni Faiz wrote:
>     > Signed-off-by: Husni Faiz <ahamedhusni73 at gmail.com
>     <mailto:ahamedhusni73 at gmail.com>>
>     > ---
>     >  rtemsbsd/include/machine/rtems-bsd-kernel-namespace.h | 5 +++++
>     >  1 file changed, 5 insertions(+)
>     >
>     > diff --git a/rtemsbsd/include/machine/rtems-bsd-kernel-namespace.h
>     b/rtemsbsd/include/machine/rtems-bsd-kernel-namespace.h
>     > index 97cdb625..ae56ad9c 100644
>     > --- a/rtemsbsd/include/machine/rtems-bsd-kernel-namespace.h
>     > +++ b/rtemsbsd/include/machine/rtems-bsd-kernel-namespace.h
>     > @@ -5279,6 +5279,7 @@
>     >  #define      usbd_do_request_proc _bsd_usbd_do_request_proc
>     >  #define      usbd_dummy_timeout _bsd_usbd_dummy_timeout
>     >  #define      usb_debug _bsd_usb_debug
>     > +#define      usb_decode_str_desc _bsd_usb_decode_str_desc
>     >  #define      usbd_enum_is_locked _bsd_usbd_enum_is_locked
>     >  #define      usbd_enum_lock _bsd_usbd_enum_lock
>     >  #define      usbd_enum_lock_sig _bsd_usbd_enum_lock_sig
>     > @@ -5515,8 +5516,12 @@
>     >  #define      usb_suspend_resume _bsd_usb_suspend_resume
>     >  #define      usb_temp_get_desc_p _bsd_usb_temp_get_desc_p
>     >  #define      usb_template _bsd_usb_template
>     > +#define      usb_template_cdce _bsd_usb_template_cdce
>     > +#define      usb_temp_setup _bsd_usb_temp_setup
>     >  #define      usb_temp_setup_by_index_p _bsd_usb_temp_setup_by_index_p
>     > +#define      usb_temp_sysctl _bsd_usb_temp_sysctl
>     >  #define      usb_temp_unload _bsd_usb_temp_unload
>     > +#define      usb_temp_unsetup _bsd_usb_temp_unsetup
>     >  #define      usb_temp_unsetup_p _bsd_usb_temp_unsetup_p
>     >  #define      usb_test_quirk _bsd_usb_test_quirk
>     >  #define      usb_test_quirk_p _bsd_usb_test_quirk_p
> 
>     How were these additions done? 
> 
>  
> I used the create-kernel-namespace.sh script which auto genarates these definitions.
> That generated more definitions than I have added here. I only filtered out the
> definitions for the codes I imported.

Thanks and yes it is wise to do this.

I am going to ask for these changes to be queued behind my posted patches for
6-freebsd-12 where I have removed the create-kernel-namespace.sh and replaced it
with a new python script.

>     I ask because I see these externs in the template code ...
> 
> 
>     extern struct usb_temp_device_desc usb_template_audio;
>     extern struct usb_temp_device_desc usb_template_cdce;
>     extern struct usb_temp_device_desc usb_template_kbd;
>     extern struct usb_temp_device_desc usb_template_modem;
>     extern struct usb_temp_device_desc usb_template_mouse;
>     extern struct usb_temp_device_desc usb_template_msc;
>     extern struct usb_temp_device_desc usb_template_mtp;
>     extern struct usb_temp_device_desc usb_template_phone;
>     extern struct usb_temp_device_desc usb_template_serialnet;
>     extern struct usb_temp_device_desc usb_template_midi;
>     extern struct usb_temp_device_desc usb_template_multi;
>     extern struct usb_temp_device_desc usb_template_cdceem;
> 
> 
> These externs are for all the usb templates supported by freebsd.
> I only have imported the usb_template_cdce. Other templates are
> not imported yet. Shall I exclude them?

All good. I was more interested in the update process than the USB side of things :)

Chris