[PATCH 05/13] posix: Remove superfluous check

Gedare Bloom gedare at rtems.org
Thu Feb 18 17:21:30 UTC 2021


On Wed, Feb 17, 2021 at 12:31 PM Sebastian Huber
<sebastian.huber at embedded-brains.de> wrote:
>
> The api pointer is never NULL.
>
> Update #4244.
> ---
>  cpukit/posix/src/psignalunblockthread.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/cpukit/posix/src/psignalunblockthread.c b/cpukit/posix/src/psignalunblockthread.c
> index 63ed823ab3..a1af20a5af 100644
> --- a/cpukit/posix/src/psignalunblockthread.c
> +++ b/cpukit/posix/src/psignalunblockthread.c
> @@ -111,12 +111,6 @@ static void _POSIX_signals_Action_handler(
>     */
>    hold_errno = executing->Wait.return_code;
>
> -  /*
> -   * api may be NULL in case of a thread close in progress
> -   */
> -  if ( !api )
> -    return;
> -
I believe you, but should we replace this with an assert for now?

>    /*
>     *  In case the executing thread is blocked or about to block on something
>     *  that uses the thread wait information, then this is a kernel bug.
> --
> 2.26.2
>
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel


More information about the devel mailing list