[PATCH 4/4] rtems-debugger-threads.c: Fix Unchecked return value error (CID #1468688)

[Gedare Bloom]

On Fri, Feb 26, 2021 at 2:35 PM Ryan Long <thisisryanlong at gmail.com> wrote:
>
> CID 1468688: Unchecked return value in snapshot_thread().
>
> Closes #4262
> ---
>  cpukit/libdebugger/rtems-debugger-threads.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/cpukit/libdebugger/rtems-debugger-threads.c b/cpukit/libdebugger/rtems-debugger-threads.c
> index 5b96e5f..ee8d654 100644
> --- a/cpukit/libdebugger/rtems-debugger-threads.c
> +++ b/cpukit/libdebugger/rtems-debugger-threads.c
> @@ -170,6 +170,7 @@ snapshot_thread(rtems_tcb* tcb, void* arg)
>    char                    name[RTEMS_DEBUGGER_THREAD_NAME_SIZE];
>    bool                    exclude = false;
>    size_t                  i;
> +  int                     sc;
>
>    /*
>     * The only time the threads pointer is NULL is a realloc error so we stop
> @@ -272,7 +273,9 @@ snapshot_thread(rtems_tcb* tcb, void* arg)
>      /*
>       * Read the target registers into the thread register array.
>       */
> -    rtems_debugger_target_read_regs(thread);
> +    sc = rtems_debugger_target_read_regs(thread);
> +    _Assert_Unused_variable_equals(sc, 0);
> +
Remove this extra blank line

>
>      if (rtems_debugger_server_flag(RTEMS_DEBUGGER_FLAG_VERBOSE))
>        rtems_debugger_printf("rtems-db: sys: thd: %08" PRIx32 ": signal: %d\n",
> --
> 1.8.3.1
>
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel