[PATCH 03/11] bsp/leon3: Fix incompatible function types

Gedare Bloom gedare at rtems.org
Fri Jan 29 16:40:50 UTC 2021


Need to fix in riscv/griscv also?

On Thu, Jan 28, 2021 at 8:28 AM Sebastian Huber <
sebastian.huber at embedded-brains.de> wrote:

> This fix relates to a Coverity issue (PW.INCOMPATIBLE_PARAM).
> ---
>  bsps/sparc/leon3/clock/ckinit.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/bsps/sparc/leon3/clock/ckinit.c
> b/bsps/sparc/leon3/clock/ckinit.c
> index bf0c506ec0..43e5f55ae5 100644
> --- a/bsps/sparc/leon3/clock/ckinit.c
> +++ b/bsps/sparc/leon3/clock/ckinit.c
> @@ -130,10 +130,10 @@ static void leon3_tc_do_tick(void)
>      } \
>    } while (0)
>
> -#define Clock_driver_support_install_isr( _new ) \
> -  bsp_clock_handler_install(_new)
> +#define Clock_driver_support_install_isr(isr) \
> +  bsp_clock_handler_install(isr)
>
> -static void bsp_clock_handler_install(rtems_isr *new)
> +static void bsp_clock_handler_install(rtems_interrupt_handler isr)
>  {
>    rtems_status_code sc;
>
> @@ -141,7 +141,7 @@ static void bsp_clock_handler_install(rtems_isr *new)
>      clkirq,
>      "Clock",
>      RTEMS_INTERRUPT_UNIQUE,
> -    new,
> +    isr,
>      NULL
>    );
>    if (sc != RTEMS_SUCCESSFUL) {
> @@ -234,6 +234,8 @@ static void leon3_clock_initialize(void)
>
>  #define Clock_driver_timecounter_tick() leon3_tc_do_tick()
>
> +#define BSP_FEATURE_IRQ_EXTENSION
> +
>  #include "../../../shared/dev/clock/clockimpl.h"
>
>  #endif
> --
> 2.26.2
>
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20210129/f4aa72a5/attachment.html>


More information about the devel mailing list