[PATCH] score: Add _Thread_Demand_objects_information()

dufault at hda.com dufault at hda.com
Fri Jan 29 17:18:41 UTC 2021



> On Jan 29, 2021, at 10:57 , Sebastian Huber <sebastian.huber at embedded-brains.de> wrote:
> 
> On 29/01/2021 15:29, dufault at hda.com wrote:
> 
>>> On Jan 28, 2021, at 09:13 , Sebastian Huber<sebastian.huber at embedded-brains.de>  wrote:
>>> 
>>>> What's the rationale for "Demand"?  Is that in use other places?
>>>> 
>>>> It sounds odd to me, as if you're insisting the function provide something that it might otherwise decide not to.
>>> "Get" was already used. This is a "Get" when we know the identifier is valid. Do you have a better verb?
>>> 
>> Valid_ID_Get?  Or is that getting too wordy?
>> 
>> I like "_ValID_" (i.e. use "ValID" in interface names for validated IDs) but that must break the rules.
> 
> What about:
> 
> _Thread_Get_objects_information() -> _Thread_Get_objects_information_by_id(Objects_Id)
> 
> _Thread_Demand_objects_information() -> _Thread_Get_objects_information(Thread_Control *)

I like that.  Since the interface change is internal to RTEMS the change in the signature isn't a big deal, and "Get_*_by_id" can be used going forward to imply the ID needs validation as opposed to getting it from a valid Thread_Control.

I have to research the RTEMS naming convention.  I know it must be well-defined and not Random_case.


Peter
-----------------
Peter Dufault
HD Associates, Inc.      Software and System Engineering

This email is delivered through the public internet using protocols subject to interception and tampering.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 235 bytes
Desc: Message signed with OpenPGP
URL: <http://lists.rtems.org/pipermail/devel/attachments/20210129/59f875d4/attachment.bin>


More information about the devel mailing list