[rtems commit] Update Strong APA Scheduler

[Richi Dubey]

Hi,

How do I reproduce this? I tried using the config produced by
------------------------------------
$ ./waf bsp_defaults --rtems-bsps=arm/realview_pbx_a9_qemu
------------------------------------

which has:
------------------------------------
# Warning flags passed to the C and C++ compiler
WARNING_FLAGS = -Wall
------------------------------------

and I enabled the SMP tests:
------------------------------------
# Enable the Symmetric Multiprocessing (SMP) support
RTEMS_SMP = True
...
# Build the test programs
BUILD_TESTS = True
------------------------------------

It still does not show me any warning during the step
------------------------------------
$ ./waf
------------------------------------

Also, why do we have both:

------------------------------------------------------------------------
# Warning flags passed to the C and C++ compiler
WARNING_FLAGS = -Wall
# Warning flags passed to the C compiler
CC_WARNING_FLAGS = -Wmissing-prototypes -Wimplicit-function-declaration
-Wstrict-prototypes -Wnested-externs
------------------------------------------------------------------------

Does not "-Wall" cover all the warnings? Why are we passing arguments for
some warnings individually when we already passed -Wall?


On Wed, Jun 30, 2021 at 11:18 PM Sebastian Huber <
sebastian.huber at embedded-brains.de> wrote:

> This patch introduced new warnings:
>
> ../../../cpukit/score/src/schedulerstrongapa.c: In function
> '_Scheduler_strong_APA_Get_highest_ready':
> ../../../cpukit/score/src/schedulerstrongapa.c:394:10: warning:
> 'highest_ready' may be used uninitialized in this function
> [-Wmaybe-uninitialized]
>    394 |       if ( curr_node == highest_ready ) {
>        |          ^
> ../../../cpukit/score/src/schedulerstrongapa.c: In function
> '_Scheduler_strong_APA_Enqueue':
> ../../../cpukit/score/src/schedulerstrongapa.c:600:38: warning:
> 'cpu_to_preempt' may be used uninitialized in this function
> [-Wmaybe-uninitialized]
>    600 |     curr_strong_node->cpu_to_preempt = cpu_to_preempt;
>        |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
> ../../../cpukit/score/src/schedulerstrongapa.c:676:33: note:
> 'cpu_to_preempt' was declared here
>    676 |   Per_CPU_Control              *cpu_to_preempt;
>        |                                 ^~~~~~~~~~~~~~
> In file included from ../../../cpukit/include/rtems/score/objectdata.h:25,
>                   from ../../../cpukit/include/rtems/score/thread.h:32,
>                   from ../../../cpukit/include/rtems/score/scheduler.h:23,
>                   from
> ../../../cpukit/include/rtems/score/schedulerstrongapa.h:41,
>                   from ../../../cpukit/score/src/schedulerstrongapa.c:67:
> ../../../cpukit/include/rtems/score/chainimpl.h:677:18: warning:
> 'lowest_reachable' may be used uninitialized in this function
> [-Wmaybe-uninitialized]
>    677 |   the_node->next = tail;
>        |   ~~~~~~~~~~~~~~~^~~~~~
> ../../../cpukit/score/src/schedulerstrongapa.c:497:32: note:
> 'lowest_reachable' was declared here
>    497 |   Scheduler_Node              *lowest_reachable;
> --
> embedded brains GmbH
> Herr Sebastian HUBER
> Dornierstr. 4
> 82178 Puchheim
> Germany
> email: sebastian.huber at embedded-brains.de
> phone: +49-89-18 94 741 - 16
> fax:   +49-89-18 94 741 - 08
>
> Registergericht: Amtsgericht München
> Registernummer: HRB 157899
> Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
> Unsere Datenschutzerklärung finden Sie hier:
> https://embedded-brains.de/datenschutzerklaerung/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20210701/2ff85965/attachment.html>