[PATCH 04/10] bsps/sparc: Add a symbol for each trap table entry

Sebastian Huber sebastian.huber at embedded-brains.de
Wed Jun 23 17:39:49 UTC 2021


On 23/06/2021 19:06, Gedare Bloom wrote:
>> +  BAD_TRAP(0x0f)                                ! 0F undefined
>> +  BAD_TRAP(0x10)                                ! 10 undefined
>>
> This code could be simplified using assembly macros (.irp) something
> like what I did in bsps/sparc64/shared/start/trap_table.S
> 
> .irp idx, 0x07, 0x08, .... 0x10
>    BAD_TRAP(\idx)
> .endr

For loops are definitely missing in the C preprocessor.

> 
> Not necessary to do, but came to my mind. Perhaps, keeping them broken
> out makes it easier to document with comments.
> 

Yes, next time it could save some editing time.

-- 
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.huber at embedded-brains.de
phone: +49-89-18 94 741 - 16
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/


More information about the devel mailing list