[PATCH] bsps/raspberrypi: Add FDT defines to build options

Sun Jun 27 20:48:49 UTC 2021

On Sun, Jun 27, 2021 at 8:33 PM Gedare Bloom <gedare at rtems.org> wrote:
>
> On Sun, Jun 27, 2021 at 8:33 AM Joel Sherrill <joel at rtems.org> wrote:
> >
> >
> >
> > On Sun, Jun 27, 2021, 9:04 AM Alan Cudmore <alan.cudmore at gmail.com> wrote:
> >>
> >> Hi,
> >> This patch works for me. I can build and run the latest rtems master
> >> branch samples on the RPI 2 and 3.
> >> The samples do not run on the single core models, but it is not
> >> related to this patch. I have a patch for the single core models, and
> >> when combined with this patch I can get the samples to run on RPI
> >> Zero, Zero W, Pi A+, Original Pi Model B+, Pi 2, and Pi 3.
> >
> >
> > This is all great news!
> >
> > Thanks to everyone who helped out on this
> >
> > --joel
> >>
> >>
> >> Thanks,
> >> Alan
> >>
> >> On Fri, Jun 25, 2021 at 12:18 PM pranav <dangipranav at gmail.com> wrote:
> >> >
> >> > ---
> >> >  spec/build/bsps/arm/raspberrypi/grp.yml         |  8 ++++++++
> >> >  spec/build/bsps/arm/raspberrypi/optfdtcpyro.yml | 15 +++++++++++++++
> >> >  spec/build/bsps/arm/raspberrypi/optfdtmxsz.yml  | 16 ++++++++++++++++
> >> >  spec/build/bsps/arm/raspberrypi/optfdtro.yml    | 15 +++++++++++++++
> >> >  spec/build/bsps/arm/raspberrypi/optfdtuboot.yml | 15 +++++++++++++++
> >> >  5 files changed, 69 insertions(+)
> >> >  create mode 100644 spec/build/bsps/arm/raspberrypi/optfdtcpyro.yml
> >> >  create mode 100644 spec/build/bsps/arm/raspberrypi/optfdtmxsz.yml
> >> >  create mode 100644 spec/build/bsps/arm/raspberrypi/optfdtro.yml
> >> >  create mode 100644 spec/build/bsps/arm/raspberrypi/optfdtuboot.yml
> >> >
> Please move the existing files from spec/build/bsps/arm/beagle/ into
> spec/build/bsps/arm, and update the grp.yml for beagle and raspberrypi
> accordingly.
>
> It is best to avoid copy-paste where possible.
>
> Resend as -v2, and check compile on beagle and rpi.
>

I've sent the v2, the files were being used in the cyclone-v and imx
too, so I've moved those out too.

> >> > diff --git a/spec/build/bsps/arm/raspberrypi/grp.yml b/spec/build/bsps/arm/raspberrypi/grp.yml
> >> > index 7291e8b178..a810fdd529 100644
> >> > --- a/spec/build/bsps/arm/raspberrypi/grp.yml
> >> > +++ b/spec/build/bsps/arm/raspberrypi/grp.yml
> >> > @@ -31,6 +31,14 @@ links:
> >> >    uid: optrpi2
> >> >  - role: build-dependency
> >> >    uid: optspiiomode
> >> > +- role: build-dependency
> >> > +  uid: optfdtuboot
> >> > +- role: build-dependency
> >> > +  uid: optfdtcpyro
> >> > +- role: build-dependency
> >> > +  uid: optfdtmxsz
> >> > +- role: build-dependency
> >> > +  uid: optfdtro
> >> >  - role: build-dependency
> >> >    uid: ../start
> >> >  - role: build-dependency
> >> > diff --git a/spec/build/bsps/arm/raspberrypi/optfdtcpyro.yml b/spec/build/bsps/arm/raspberrypi/optfdtcpyro.yml
> >> > new file mode 100644
> >> > index 0000000000..c26b1ae051
> >> > --- /dev/null
> >> > +++ b/spec/build/bsps/arm/raspberrypi/optfdtcpyro.yml
> >> > @@ -0,0 +1,15 @@
> >> > +SPDX-License-Identifier: CC-BY-SA-4.0 OR BSD-2-Clause
> >> > +actions:
> >> > +- get-boolean: null
> >> > +- define-condition: null
> >> > +build-type: option
> >> > +copyrights:
> >> > +- Copyright (C) 2020 embedded brains GmbH (http://www.embedded-brains.de)
> >> > +default: true
> >> > +default-by-variant: []
> >> > +description: |
> >> > +  copy the FDT blob into the read-only load area via bsp_fdt_copy()
> >> > +enabled-by: true
> >> > +links: []
> >> > +name: BSP_FDT_BLOB_COPY_TO_READ_ONLY_LOAD_AREA
> >> > +type: build
> >> > diff --git a/spec/build/bsps/arm/raspberrypi/optfdtmxsz.yml b/spec/build/bsps/arm/raspberrypi/optfdtmxsz.yml
> >> > new file mode 100644
> >> > index 0000000000..14af766230
> >> > --- /dev/null
> >> > +++ b/spec/build/bsps/arm/raspberrypi/optfdtmxsz.yml
> >> > @@ -0,0 +1,16 @@
> >> > +SPDX-License-Identifier: CC-BY-SA-4.0 OR BSD-2-Clause
> >> > +actions:
> >> > +- get-integer: null
> >> > +- define: null
> >> > +build-type: option
> >> > +copyrights:
> >> > +- Copyright (C) 2020 embedded brains GmbH (http://www.embedded-brains.de)
> >> > +default: 262144
> >> > +default-by-variant: []
> >> > +description: |
> >> > +  maximum size of the FDT blob in bytes
> >> > +enabled-by: true
> >> > +format: '{}'
> >> > +links: []
> >> > +name: BSP_FDT_BLOB_SIZE_MAX
> >> > +type: build
> >> > diff --git a/spec/build/bsps/arm/raspberrypi/optfdtro.yml b/spec/build/bsps/arm/raspberrypi/optfdtro.yml
> >> > new file mode 100644
> >> > index 0000000000..a61bb2924b
> >> > --- /dev/null
> >> > +++ b/spec/build/bsps/arm/raspberrypi/optfdtro.yml
> >> > @@ -0,0 +1,15 @@
> >> > +SPDX-License-Identifier: CC-BY-SA-4.0 OR BSD-2-Clause
> >> > +actions:
> >> > +- get-boolean: null
> >> > +- define-condition: null
> >> > +build-type: option
> >> > +copyrights:
> >> > +- Copyright (C) 2020 embedded brains GmbH (http://www.embedded-brains.de)
> >> > +default: true
> >> > +default-by-variant: []
> >> > +description: |
> >> > +  place the FDT blob into the read-only data area
> >> > +enabled-by: true
> >> > +links: []
> >> > +name: BSP_FDT_BLOB_READ_ONLY
> >> > +type: build
> >> > diff --git a/spec/build/bsps/arm/raspberrypi/optfdtuboot.yml b/spec/build/bsps/arm/raspberrypi/optfdtuboot.yml
> >> > new file mode 100644
> >> > index 0000000000..5805e912ff
> >> > --- /dev/null
> >> > +++ b/spec/build/bsps/arm/raspberrypi/optfdtuboot.yml
> >> > @@ -0,0 +1,15 @@
> >> > +SPDX-License-Identifier: CC-BY-SA-4.0 OR BSD-2-Clause
> >> > +actions:
> >> > +- get-boolean: null
> >> > +- define-condition: null
> >> > +build-type: option
> >> > +copyrights:
> >> > +- Copyright (C) 2020 embedded brains GmbH (http://www.embedded-brains.de)
> >> > +default: true
> >> > +default-by-variant: []
> >> > +description: |
> >> > +  copy the U-Boot provided FDT to an internal storage
> >> > +enabled-by: true
> >> > +links: []
> >> > +name: BSP_START_COPY_FDT_FROM_U_BOOT
> >> > +type: build
> >> > --
> >> > 2.27.0
> >> >
> >> > _______________________________________________
> >> > devel mailing list
> >> > devel at rtems.org
> >> > http://lists.rtems.org/mailman/listinfo/devel
> >> _______________________________________________
> >> devel mailing list
> >> devel at rtems.org
> >> http://lists.rtems.org/mailman/listinfo/devel
> >
> > _______________________________________________
> > devel mailing list
> > devel at rtems.org
> > http://lists.rtems.org/mailman/listinfo/devel
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel