[PATCH 1/3] grtc.c: Fix four Missing break in switch Coverity errors

Ryan Long thisisryanlong at gmail.com
Wed Mar 3 21:25:59 UTC 2021


CID 1399761: Missing break in switch in process_dma().
CID 1399765: Missing break in switch in process_dma().
CID 1399766: Missing break in switch in process_dma().
CID 1399777: Missing break in switch in process_dma().

Closes #4277
---
 bsps/shared/grlib/tmtc/grtc.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/bsps/shared/grlib/tmtc/grtc.c b/bsps/shared/grlib/tmtc/grtc.c
index e9acea4..f734f2e 100644
--- a/bsps/shared/grlib/tmtc/grtc.c
+++ b/bsps/shared/grlib/tmtc/grtc.c
@@ -1365,6 +1365,7 @@ static int process_dma(struct grtc_priv *pDev)
 		/* Start of frame found, Try to copy header */
 		pDev->frm = NULL;
 		pDev->frame_state = FRM_STATE_HDR;
+		/* Fall through */
 
 		case FRM_STATE_HDR:
 		DBG2("FRAME_STATE_HDR\n");
@@ -1396,6 +1397,7 @@ static int process_dma(struct grtc_priv *pDev)
 			return -1;
 		}
 		pDev->frame_state = FRM_STATE_ALLOC;
+		/* Fall through */
 
 		case FRM_STATE_ALLOC:
 		DBG2("FRAME_STATE_ALLOC\n");
@@ -1449,6 +1451,7 @@ static int process_dma(struct grtc_priv *pDev)
 
 		pDev->frame_state = FRM_STATE_PAYLOAD;
 		pDev->frm = frm;
+		/* Fall through */
 
 		case FRM_STATE_PAYLOAD:
 		DBG2("FRAME_STATE_PAYLOAD\n");
@@ -1476,6 +1479,7 @@ static int process_dma(struct grtc_priv *pDev)
 		}
 		frm->len += ret;
 		pDev->frame_state = FRM_STATE_FILLER;
+		/* Fall through */
 
 		case FRM_STATE_FILLER:
 		DBG2("FRAME_STATE_FILLER\n");
-- 
1.8.3.1



More information about the devel mailing list