[PATCH 00/12] Fix grlib/gr device driver Coverity errors

Ryan Long thisisryanlong at gmail.com
Thu Mar 4 19:50:13 UTC 2021


Hi,

Here are the fixes for the Coverity errors with grlib/gr device drivers.

The types of issues fixed were:
- Unchecked return value
- Unchecked return value from library
- Unsigned compared against 0
- Unused value

For the "Unsigned compared against 0" errors in satcan.c, the first if
statements were not being used, so they were taken out.

Thanks,
Ryan

Ryan Long (12):
  grspw.c: Fix Unchecked return value (CID #1399781)
  gr_rasta_spw_router.c: Fix Unchecked return value from library (CID
    #1399760)
  gr_rasta_io.c: Fix Unchecked return value from library (CID #1399763)
  gr_leon4_n2x.c: Fix Unchecked return value from library (CID #1399767)
  gr_rasta_tmtc.c: Fix Unchecked return value from library (CID
    #1399771)
  gr_rasta_tmtc.c: Fix Unchecked return value from library (CID
    #1399780)
  gr_701.c: Unchecked return value from library (CID #1399783)
  gr_tmtc_1553.c: Unchecked return value from library (CID #1399785)
  gr_cpci_gr740.c: Unchecked return value from library (CID #1437630)
  satcan.c: Fix Unsigned compared against 0 (CID #1399768)
  b1553brm.c: Fix Unsigned compared against 0 (CID #1399773)
  grcan.c: Fix Unused value (CID #1437613)

 bsps/shared/grlib/1553/b1553brm.c           |  2 +-
 bsps/shared/grlib/can/grcan.c               |  2 +-
 bsps/shared/grlib/can/satcan.c              | 16 ++++------------
 bsps/shared/grlib/pci/gr_701.c              |  4 +++-
 bsps/shared/grlib/pci/gr_rasta_adcdac.c     |  4 +++-
 bsps/shared/grlib/pci/gr_rasta_io.c         |  4 +++-
 bsps/shared/grlib/pci/gr_rasta_spw_router.c |  4 +++-
 bsps/shared/grlib/pci/gr_rasta_tmtc.c       |  4 +++-
 bsps/shared/grlib/pci/gr_tmtc_1553.c        |  4 +++-
 bsps/shared/grlib/spw/grspw.c               |  7 +++++--
 bsps/sparc/shared/pci/gr_cpci_gr740.c       |  4 +++-
 bsps/sparc/shared/pci/gr_leon4_n2x.c        |  4 +++-
 12 files changed, 35 insertions(+), 24 deletions(-)

-- 
1.8.3.1



More information about the devel mailing list