[PATCH 1/5] hexdump-parse.c: Fix Resource leak (CID #26032)

Chris Johns chrisj at rtems.org
Mon Mar 15 00:30:07 UTC 2021


On 13/3/21 2:18 am, Ryan Long wrote:
> CID 26032: Resource leak in rtems_shell_hexdump_rewrite().
> 
> Closes #4296
> ---
>  cpukit/libmisc/shell/hexdump-parse.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/cpukit/libmisc/shell/hexdump-parse.c b/cpukit/libmisc/shell/hexdump-parse.c
> index 88b9d56..5b56bbf 100644
> --- a/cpukit/libmisc/shell/hexdump-parse.c
> +++ b/cpukit/libmisc/shell/hexdump-parse.c
> @@ -462,6 +462,9 @@ isint2:					switch(fu->bcnt) {
>  		(void)printf("\n");
>  	}
>  #endif
> +#ifdef __rtems__
> +	free(nextpr);
> +#endif

I know this has not been done in imported code in rtems.git before but should we
adopt the libbsd standard of adding /* __rtems__ */ to the #else and #endif?

Chris


More information about the devel mailing list