[PATCH 1/5] hexdump-parse.c: Fix Resource leak (CID #26032)

[Gedare Bloom]

On Sun, Mar 14, 2021 at 8:27 PM Chris Johns <chrisj at rtems.org> wrote:
>
> On 13/3/21 2:18 am, Ryan Long wrote:
> > CID 26032: Resource leak in rtems_shell_hexdump_rewrite().
> >
> > Closes #4296
> > ---
> >  cpukit/libmisc/shell/hexdump-parse.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/cpukit/libmisc/shell/hexdump-parse.c b/cpukit/libmisc/shell/hexdump-parse.c
> > index 88b9d56..5b56bbf 100644
> > --- a/cpukit/libmisc/shell/hexdump-parse.c
> > +++ b/cpukit/libmisc/shell/hexdump-parse.c
> > @@ -462,6 +462,9 @@ isint2:                                   switch(fu->bcnt) {
> >               (void)printf("\n");
> >       }
> >  #endif
> > +#ifdef __rtems__
> > +     free(nextpr);
> > +#endif
>
> I know this has not been done in imported code in rtems.git before but should we
> adopt the libbsd standard of adding /* __rtems__ */ to the #else and #endif?
>

Probably, but we also clone-and-own this shell/ code, and we should
not bother with these #ifdefs in there. I think I have said this 3
times this past week about shell/. The upstream does not want our
changes, and we don't import from them anymore.

> Chris
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel