[PATCH v4] cpukit/aarch64: Add ESR register decoding

Joel Sherrill joel at rtems.org
Tue Mar 23 15:57:12 UTC 2021


On Tue, Mar 23, 2021 at 10:49 AM Sebastian Huber <
sebastian.huber at embedded-brains.de> wrote:

> Hello Alex,
>
> this file has little in common with the RTEMS coding style. This is
> quite understandable since the style is very exotic. I don't think we
> will have a formatting tool which is able to produce the RTEMS style in
> the near future. This gives raise to some general questions.
>
> 1. Do we care about the coding style?
>

Yes.

>
> 2. Who wants to enforce the coding style?
>

I hope we all catch these when we spot them.

Alex will reformat it.


>
> 3. Should new files use a new style understood by a well known tool and
> a well known coding style?
>

That would be preferable but like the license change and SPDX markers, this
is down the list.

You have something that is close. If you want to add it to rtems-tools as a
starting
point that is accessible, we can start to use it and see how it goes.


>
> I see a lot of
>
> type var = initial_value;
>
> Maybe we should drop the stone age variable declarations at block begin
> if we choose a new style and declare and initialize local variables upon
> first use.
>

I don't know when this was started but it was never part of the original
RTEMS style.

Personally I have never liked it.

--joel


>
> --
> embedded brains GmbH
> Herr Sebastian HUBER
> Dornierstr. 4
> 82178 Puchheim
> Germany
> email: sebastian.huber at embedded-brains.de
> phone: +49-89-18 94 741 - 16
> fax:   +49-89-18 94 741 - 08
>
> Registergericht: Amtsgericht München
> Registernummer: HRB 157899
> Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
> Unsere Datenschutzerklärung finden Sie hier:
> https://embedded-brains.de/datenschutzerklaerung/
>
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20210323/c0b98b51/attachment.html>


More information about the devel mailing list