[PATCH] rtemstoolkit/mailer.py: Fix option ordering for add_arguments

Chris Johns chrisj at rtems.org
Thu May 6 03:15:36 UTC 2021

On 6/5/21 4:49 am, Gedare Bloom wrote:
> On Wed, May 5, 2021 at 9:16 AM Alex White <alex.white at oarcorp.com> wrote:
>> On Wed, May 5, 2021 at 9:47 AM Gedare Bloom <gedare at rtems.org> wrote:
>>> Why?
>> To prevent the '--mail' and '--use-gitconfig' options from being added more than once to the ArgumentParser in add_arguments.
> How does that happen?
> I'm not trying to be frustrating (just annoying). I want to be sure
> we're using the right solution for the right problem, and not just
> putting a bandaid over something so it works while we hide some
> underlying concerns.

Gedare, I am agree. I think there maybe another simpler solution.

Why not make the list() be something like ...

  no_add = ['--mail', '--use-gitconfig']
  for o in [opt for opt in list(_options) if not in no_add]:

... or something like that?


More information about the devel mailing list