[PATCH] cpukit/libmisc/monitor: Fixed src/dest overlap in strcpy in mon-editor.c
Harrison Edward Gerber
gerberhe11 at gmail.com
Wed May 26 22:35:12 UTC 2021
See also CID 1399727
Closes #4444
---
cpukit/libmisc/monitor/mon-editor.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/cpukit/libmisc/monitor/mon-editor.c b/cpukit/libmisc/monitor/mon-editor.c
index dcea9fcc69..1392be51f1 100644
--- a/cpukit/libmisc/monitor/mon-editor.c
+++ b/cpukit/libmisc/monitor/mon-editor.c
@@ -360,7 +360,8 @@ rtems_monitor_line_editor (
{
int bs;
pos--;
- strcpy (buffer + pos, buffer + pos + 1);
+ memmove(buffer + pos, buffer + pos + 1, RTEMS_COMMAND_BUFFER_SIZE - pos - 1);
+ buffer[RTEMS_COMMAND_BUFFER_SIZE - 1] = "\0";
fprintf(stdout,"\b%s \b", buffer + pos);
for (bs = 0; bs < ((int) strlen (buffer) - pos); bs++)
putchar ('\b');
--
2.25.1
More information about the devel
mailing list