[PATCH v2 3/3] main_help.c: Do not care what char is returned by getchar()

[Ryan Long]

You acked them, and I sent the tarball with the patches to Joel. So I think Joel just forgot to put them in.

-----Original Message-----
From: Gedare Bloom <gedare at rtems.org> 
Sent: Friday, May 28, 2021 9:55 AM
To: Ryan Long <ryan.long at oarcorp.com>
Cc: devel at rtems.org
Subject: Re: [PATCH v2 3/3] main_help.c: Do not care what char is returned by getchar()

Are these three still pending? If so, can you ping the other 2 or advise what is blocking?

On Mon, Apr 5, 2021 at 7:28 AM Ryan Long <ryan.long at oarcorp.com> wrote:
>
> CID 1437650: Unchecked return value from library in rtems_shell_help().
>
> Closes #4291
> ---
>  cpukit/libmisc/shell/main_help.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/cpukit/libmisc/shell/main_help.c 
> b/cpukit/libmisc/shell/main_help.c
> index 9f59e9d..564bc30 100644
> --- a/cpukit/libmisc/shell/main_help.c
> +++ b/cpukit/libmisc/shell/main_help.c
> @@ -148,7 +148,7 @@ static int rtems_shell_help(
>          line+= rtems_shell_help_cmd(shell_cmd);
>        if (lines && (line > lines)) {
>          printf("Press any key to continue...");
> -        getchar();
> +        (void) getchar();
>          printf("\n");
>          line = 0;
>        }
> --
> 1.8.3.1
>
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel