[PATCH 14/27] Remove double-calls to tc_get_timecount()

Moyano, Gabriel gabriel.moyano at dlr.de
Wed Nov 17 07:50:26 UTC 2021


From: Konstantin Belousov <kib at FreeBSD.org>

to warm timecounters.

It seems that second call does not add any useful state change for all
implemented timecounters.

Discussed with:	bde
Sponsored by:	The FreeBSD Foundation
MFC after:	3 weeks
---
 cpukit/score/src/kern_tc.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/cpukit/score/src/kern_tc.c b/cpukit/score/src/kern_tc.c
index 1756ac1cb8..69af591d91 100644
--- a/cpukit/score/src/kern_tc.c
+++ b/cpukit/score/src/kern_tc.c
@@ -1376,7 +1376,6 @@ tc_init(struct timecounter *tc)
 		return;
 #ifndef __rtems__
 	(void)tc->tc_get_timecount(tc);
-	(void)tc->tc_get_timecount(tc);
 #endif /* __rtems__ */
 	timecounter = tc;
 #ifdef __rtems__
@@ -1692,7 +1691,6 @@ sysctl_kern_timecounter_hardware(SYSCTL_HANDLER_ARGS)
 
 		/* Warm up new timecounter. */
 		(void)newtc->tc_get_timecount(newtc);
-		(void)newtc->tc_get_timecount(newtc);
 
 		timecounter = newtc;
 
@@ -2247,7 +2245,6 @@ inittimecounter(void *dummy)
 
 	/* warm up new timecounter (again) and get rolling. */
 	(void)timecounter->tc_get_timecount(timecounter);
-	(void)timecounter->tc_get_timecount(timecounter);
 	mtx_lock_spin(&tc_setclock_mtx);
 	tc_windup(NULL);
 	mtx_unlock_spin(&tc_setclock_mtx);
-- 
2.17.1



More information about the devel mailing list