[PATCH 3/4] rtemsbsd/nfsclient: Fix the error code return value

Chris Johns chrisj at rtems.org
Wed Oct 20 23:01:22 UTC 2021


On 21/10/21 9:59 am, Joel Sherrill wrote:
> On Wed, Oct 20, 2021, 12:49 AM Sebastian Huber
> <sebastian.huber at embedded-brains.de <mailto:sebastian.huber at embedded-brains.de>>
> wrote:
>     On 20/10/2021 05:16, chrisj at rtems.org <mailto:chrisj at rtems.org> wrote:
>     > +     errno = 0;
>     > +     return 0;
> 
>     I think setting errno if no error occurred is not allowed.
> Right. Convention is that errno should not be touched by implementation or read
> by application unless -1 is returned.
> 

Fantastic and thank you for the review and feedback.

I will remove this and push the patches.

Chris


More information about the devel mailing list