[PATCH] spec/libdebugger: Only enable for supported architectures

[Sebastian Huber]

On 21/10/2021 07:45, Chris Johns wrote:
> On 21/10/21 4:30 pm, Sebastian Huber wrote:
>> On 21/10/2021 04:09, chrisj at rtems.org wrote:
>>> From: Chris Johns<chrisj at rtems.org>
>>>
>>> ---
>>>    spec/build/cpukit/libdebugger.yml             | 5 ++++-
>>>    spec/build/testsuites/libtests/debugger01.yml | 4 +---
>>>    2 files changed, 5 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/spec/build/cpukit/libdebugger.yml
>>> b/spec/build/cpukit/libdebugger.yml
>>> index f316cc18e8..4e689044e7 100644
>>> --- a/spec/build/cpukit/libdebugger.yml
>>> +++ b/spec/build/cpukit/libdebugger.yml
>>> @@ -5,7 +5,9 @@ copyrights:
>>>    - Copyright (C) 2020 embedded brains GmbH (http://www.embedded-brains.de)
>>>    cppflags: []
>>>    cxxflags: []
>>> -enabled-by: true
>>> +enabled-by:
>>> +- arm
>>> +- i386
>>>    includes: []
>>>    install: []
>>>    install-path: ${BSP_LIBDIR}
>>> @@ -24,4 +26,5 @@ source:
>>>    - cpukit/libdebugger/rtems-debugger-target.c
>>>    - cpukit/libdebugger/rtems-debugger-threads.c
>>>    target: debugger
>>> +name: BUILD_LIBDEBUGGER
>>>    type: build
>>
>> Library items cannot have a name. You need an option item for this.
> 
> An option implies it is user configurable and it is not. How would you pass the
> enable-it state to the tests?

Yes, all options can be set by the user.

> 
> If there is another approach could be please explain how this is to handled?

One only option is to use an option.

> 
> The waf build for libdebugger is broken. The library should only be built for
> the archs that have a backend. As it currently is the library is created and
> installed and this is hidden by the fact the test is conditional on the archs
> and not the library being built. This is now exposed by Kinsey's patch to
> libbsd. LibBSD does not build.
> 
> I based adding the name on libdl. It seems libdl is done differently and I have
> no idea why and how it works.

libdl uses an option:

spec/build/cpukit/optlibdl.yml

-- 
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.huber at embedded-brains.de
phone: +49-89-18 94 741 - 16
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/