[PATCH] eng: Remove bogus coding rule

Kinsey Moore kinsey.moore at oarcorp.com
Thu Sep 2 14:41:08 UTC 2021


This change looks good.

On 9/2/2021 04:21, Sebastian Huber wrote:
> Declaring functions used only through function pointers as inline makes
> absolutely no sense at all.
> ---
>   eng/coding-conventions.rst | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/eng/coding-conventions.rst b/eng/coding-conventions.rst
> index 668a917..575dd44 100644
> --- a/eng/coding-conventions.rst
> +++ b/eng/coding-conventions.rst
> @@ -219,8 +219,6 @@ Performance
>   * Understand the constraints of `real-time programming <https://devel.rtems.org/wiki/TBR/Review/Real-Time_Resources>`_..
>     Limit execution times in interrupt contexts and critical sections,
>     such as Interrupt and Timer Service Routines (TSRs).
> -* Functions used only through function pointers should be declared
> -  'static inline' (RTEMS_INLINE_ROUTINE)
>   * Prefer to ++preincrement instead of postincrement++.
>   * Avoid using floating point except where absolutely necessary.
>   


More information about the devel mailing list