[PATCH 6/7] score: Always validate ticks in _TOD_Validate()

Chris Johns chrisj at rtems.org
Mon Sep 6 07:55:51 UTC 2021


On 6/9/21 3:49 pm, Sebastian Huber wrote:
> On 04/09/2021 06:20, Joel Sherrill wrote:
>>      > -    sc = _TOD_Validate(&temp_tod, TOD_ENABLE_TICKS_VALIDATION);
>>      > +    sc = _TOD_Validate(&temp_tod);
>>
>>     This has leaked out of the internal implementation interface. Should it?
>>
>>     I prefer this does not happen and BSPs use an API.
>>
>>
>> I noticed this also. It needs an API.
> 
> There is no RTEMS API to support writing realtime clock drivers currently. 

Where did the RTC API connection comes from? I was only thinking of a call in
`rtems/clock.h` to validate time. I would not expect an RTC API to result in the
validate call being moved from where it is.

> I am not that sure if this is really a high priority issue.

If you mean an RTC API, sure I agree with that. If this is about dipping
directly into the score, I do not agree, it is always a priority.

Chris


More information about the devel mailing list