[PATCH 6/7] score: Always validate ticks in _TOD_Validate()

Sebastian Huber sebastian.huber at embedded-brains.de
Mon Sep 6 08:11:10 UTC 2021



On 06/09/2021 09:55, Chris Johns wrote:
> On 6/9/21 3:49 pm, Sebastian Huber wrote:
>> On 04/09/2021 06:20, Joel Sherrill wrote:
>>>       > -    sc = _TOD_Validate(&temp_tod, TOD_ENABLE_TICKS_VALIDATION);
>>>       > +    sc = _TOD_Validate(&temp_tod);
>>>
>>>      This has leaked out of the internal implementation interface. Should it?
>>>
>>>      I prefer this does not happen and BSPs use an API.
>>>
>>>
>>> I noticed this also. It needs an API.
>> There is no RTEMS API to support writing realtime clock drivers currently.
> Where did the RTC API connection comes from? I was only thinking of a call in
> `rtems/clock.h` to validate time. I would not expect an RTC API to result in the
> validate call being moved from where it is.

This is not the only _TOD_* stuff used by RTC drivers.

> 
>> I am not that sure if this is really a high priority issue.
> If you mean an RTC API, sure I agree with that. If this is about dipping
> directly into the score, I do not agree, it is always a priority.

The _TOD_* stuff is probably used for decades in RTC drivers. Adding 
RTEMS API functions is a bit of work and all core developers are busy. I 
think it is unrealistic that someone will have time to work on this topic.

-- 
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.huber at embedded-brains.de
phone: +49-89-18 94 741 - 16
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/


More information about the devel mailing list