[PATCH v5 1/4] bsps/stm32f4 Include STM32F4 HAL

Duc Doan dtbpkmte at gmail.com
Mon Aug 1 02:13:23 UTC 2022


Hello Christian,

On Sun, 2022-07-31 at 20:01 +0200, oss at c-mauderer.de wrote:
> Hello Duc,
> 
> Am 31.07.22 um 17:07 schrieb Duc Doan:
> > Hello Christian,
> > 
> > On Sat, 2022-07-30 at 16:32 +0200, oss at c-mauderer.de wrote:
> > > Hello Duc,
> > > 
> > > general note for the patch: Please write in the commit message
> > > where
> > > you
> > > got the sources from. That can be a link to a github repo
> > > including a
> > > commit ID or a link to the zip file from ST (including a date,
> > > version
> > > or similar information). If you moved some stuff around compared
> > > to
> > > the
> > > original structure: Please describe about what you did. For
> > > example
> > > in
> > > the imxrt I just added the cp commands that I used:
> > > 
> > >   
> > > https://git.rtems.org/rtems/commit/bsps/arm/imxrt?id=48f6a6c302a3e1a3f8915e2503d0fe618d1af285
> > > 
> > > Not the best solution but at least someone else can find out
> > > roughly
> > > what I did.
> > > 
> > 
> > Ah yes, I will do that. I thought I only needed to put the
> > description
> > in the email before.
> > 
> > > Am 24.07.22 um 14:01 schrieb Duc Doan:
> > > > This patch is too large so I cannot send via email. Please find
> > > > it
> > > > here:
> > > > https://github.com/dtbpkmte/GSoC-2022-RTEMS/commit/6f1fbc7dd7a5e0877d8bff11e1b21558928dbc16
> > > > 
> > > > ---
> > > >    .gitignore                                    |     1 +
> > > 
> > > You added a "patches" directory to the gitignore. That looks like
> > > a
> > > change that is specific to your method of working. These kind of
> > > changes
> > > should normall not be pushed.
> > > 
> > > If you want to ignore stuff specific to your work environment, I
> > > recommend to use a global .gitignore file. Git has a
> > > "core.excludesfile"
> > > config for that.
> > > 
> > 
> > Thanks for the suggestion, I will fix that.
> > 
> > > >    bsps/arm/include/cmsis_compiler.h             |   266 +
> > > >    bsps/arm/include/cmsis_gcc.h                  |  3460 +--
> > > >    bsps/arm/include/cmsis_version.h              |    39 +
> > > >    bsps/arm/include/core_cm4.h                   |   524 +-
> > > >    bsps/arm/include/core_cm7.h                   |  5186 ++--
> > > >    bsps/arm/include/mpu_armv7.h                  |   270 +
> > > 
> > > Are the cmsis files from the same source or directly from ARM?
> > > 
> > 
> > They are from the same source (STM HAL v1.27.1).
> > 
> > > The cmsis_gcc.h has a lot of changes compared to the earlier
> > > version
> > > that has been present in RTEMS. A lot of the changes seem to be
> > > whitespace changes. Can these be avoided somehow (for example by
> > > using
> > > dos2unix before overwriting the file)?
> > > 
> > 
> > From what I've just read about dos2unix, it converts line breaks
> > from
> > CRLF to LF (please correct me if I'm wrong). How will this command
> > resolve the whitespace changes?
> 
> I haven't looked at the exact type of whitespace changes. I had the 
> impression that the difference is most likely only the line ending.
> It 
> didn't look like tab / space issue. Is it a tab / space issue?
> 

I've looked at the some files and noticed that the difference is mostly
additional code/code change (e.g. adding support for ARMv8), but not
whitespace changes.

> > 
> > > In the discord chat there was one suggestion from Ho Kaido to
> > > move
> > > the
> > > files one level down and make them BSP specific. I'm not sure
> > > whether
> > > I'm for or against that idea. Advantage is that it makes BSPs
> > > independant from each other. Disadvantage is that it duplicates
> > > code.
> > > 
> > > I think I would try to avoid moving them down due to the code
> > > duplication but it raises the question: Which BSPs use the files
> > > too
> > > and
> > > did you try whether they still compile after the upgrade?
> > > 
> > 
> > Until now I only know of STM32H7 BSP that is using the CMSIS files.
> > I
> > tried compiling it before and Karel also confirmed that the BSP
> > compiles.
> 
> Just as an example: core_cm4/7.h is included at least in stm32f4, 
> stm32h7, atsam and imxrt. So we have to make sure that these three
> are 
> compile-clean. Please use grep to find out where the headers are 
> included and check whether I maybe missed a BSP.
> 

I have checked using grep (grep -rl ~/gsoc2022/src/rtems/bsps/arm -e
"cmsis\|core_cm" and found that stm32f4, imxrt, stm32h7, and atsam are
using CMSIS files (you remembered all correctly!). I've checked and all
4 of them compile without error.

Best,

Duc

> > 
> > > 
> > > >    .../stm32f4/hal/Legacy/stm32f4xx_hal_can.c    |  1679 ++
> > > >    .../stm32f4/hal/Legacy/stm32f4xx_hal_eth.c    |  2307 ++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal.c          |   615 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_adc.c      |  2110 ++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_adc_ex.c   |  1112 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_can.c      |  2462 ++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_cec.c      |   996 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_cortex.c   |   502 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_crc.c      |   328 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_cryp.c     |  7132 ++++++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_cryp_ex.c  |   680 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_dac.c      |  1341 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_dac_ex.c   |   495 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_dcmi.c     |  1161 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_dcmi_ex.c  |   182 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_dfsdm.c    |  4423 ++++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_dma.c      |  1305 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_dma2d.c    |  2126 ++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_dma_ex.c   |   313 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_dsi.c      |  2760 +++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_eth.c      |  3220 +++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_exti.c     |   547 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_flash.c    |   775 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_flash_ex.c |  1347 +
> > > >    .../stm32f4/hal/stm32f4xx_hal_flash_ramfunc.c |   172 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_fmpi2c.c   |  6864 ++++++
> > > >    .../arm/stm32f4/hal/stm32f4xx_hal_fmpi2c_ex.c |   258 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_fmpsmbus.c |  2749 +++
> > > >    .../stm32f4/hal/stm32f4xx_hal_fmpsmbus_ex.c   |   145 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_gpio.c     |   533 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_hash.c     |  3514 +++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_hash_ex.c  |  1040 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_hcd.c      |  1728 ++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_i2c.c      |  7524 ++++++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_i2c_ex.c   |   182 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_i2s.c      |  2094 ++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_i2s_ex.c   |  1135 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_irda.c     |  2687 ++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_iwdg.c     |   262 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_lptim.c    |  2484 ++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_ltdc.c     |  2215 ++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_ltdc_ex.c  |   151 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_mmc.c      |  3201 +++
> > > >    .../stm32f4/hal/stm32f4xx_hal_msp_template.c  |   100 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_nand.c     |  2405 ++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_nor.c      |  1543 ++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_pccard.c   |   946 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_pcd.c      |  2387 ++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_pcd_ex.c   |   341 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_pwr.c      |   571 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_pwr_ex.c   |   600 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_qspi.c     |  2915 +++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_rcc.c      |  1122 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_rcc_ex.c   |  3784 +++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_rng.c      |   867 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_rtc.c      |  1896 ++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_rtc_ex.c   |  1878 ++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_sai.c      |  2554 ++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_sai_ex.c   |   310 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_sd.c       |  3277 +++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_sdram.c    |  1308 +
> > > >    .../arm/stm32f4/hal/stm32f4xx_hal_smartcard.c |  2364 ++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_smbus.c    |  2784 +++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_spdifrx.c  |  1627 ++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_spi.c      |  3915 +++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_sram.c     |  1110 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_tim.c      |  7621 ++++++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_tim_ex.c   |  2428 ++
> > > >    ...tm32f4xx_hal_timebase_rtc_alarm_template.c |   318 +
> > > >    ...m32f4xx_hal_timebase_rtc_wakeup_template.c |   293 +
> > > >    .../hal/stm32f4xx_hal_timebase_tim_template.c |   177 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_uart.c     |  3751 +++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_usart.c    |  2838 +++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_hal_wwdg.c     |   420 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_ll_adc.c       |   922 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_ll_crc.c       |   103 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_ll_dac.c       |   280 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_ll_dma.c       |   423 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_ll_dma2d.c     |   594 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_ll_exti.c      |   212 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_ll_fmc.c       |  1498 ++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_ll_fmpi2c.c    |   217 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_ll_fsmc.c      |  1062 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_ll_gpio.c      |   303 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_ll_i2c.c       |   251 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_ll_lptim.c     |   301 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_ll_pwr.c       |    81 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_ll_rcc.c       |  1660 ++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_ll_rng.c       |   111 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_ll_rtc.c       |   838 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_ll_sdmmc.c     |  1578 ++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_ll_spi.c       |   624 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_ll_tim.c       |  1189 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_ll_usart.c     |   500 +
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_ll_usb.c       |  2224 ++
> > > >    bsps/arm/stm32f4/hal/stm32f4xx_ll_utils.c     |   749 +
> > > >    bsps/arm/stm32f4/hal/system_stm32f4xx.c       |   747 +
> > > >    .../stm32f4/include/Legacy/stm32_hal_legacy.h |  4014 +++
> > > >    .../include/Legacy/stm32f4xx_hal_can_legacy.h |   765 +
> > > >    .../include/Legacy/stm32f4xx_hal_eth_legacy.h |  2209 ++
> > > >    bsps/arm/stm32f4/include/bsp.h                |     4 +
> > > >    bsps/arm/stm32f4/include/bsp/io.h             |     4 +
> > > >    bsps/arm/stm32f4/include/stm32f401xc.h        |  8641
> > > > +++++++
> > > >    bsps/arm/stm32f4/include/stm32f401xe.h        |  8641
> > > > +++++++
> > > >    bsps/arm/stm32f4/include/stm32f405xx.h        | 14310
> > > > +++++++++++
> > > >    bsps/arm/stm32f4/include/stm32f407xx.h        | 15607
> > > > ++++++++++++
> > > >    bsps/arm/stm32f4/include/stm32f410cx.h        |  7357 ++++++
> > > >    bsps/arm/stm32f4/include/stm32f410rx.h        |  7361 ++++++
> > > >    bsps/arm/stm32f4/include/stm32f410tx.h        |  7306 ++++++
> > > >    bsps/arm/stm32f4/include/stm32f411xe.h        |  8680
> > > > +++++++
> > > >    bsps/arm/stm32f4/include/stm32f412cx.h        | 13507
> > > > ++++++++++
> > > >    bsps/arm/stm32f4/include/stm32f412rx.h        | 14500
> > > > +++++++++++
> > > >    bsps/arm/stm32f4/include/stm32f412vx.h        | 14512
> > > > +++++++++++
> > > >    bsps/arm/stm32f4/include/stm32f412zx.h        | 14537
> > > > +++++++++++
> > > >    bsps/arm/stm32f4/include/stm32f413xx.h        | 15462
> > > > ++++++++++++
> > > >    bsps/arm/stm32f4/include/stm32f415xx.h        | 14595
> > > > +++++++++++
> > > >    bsps/arm/stm32f4/include/stm32f417xx.h        | 15887
> > > > ++++++++++++
> > > >    bsps/arm/stm32f4/include/stm32f423xx.h        | 15615
> > > > ++++++++++++
> > > >    bsps/arm/stm32f4/include/stm32f427xx.h        | 16827
> > > > +++++++++++++
> > > >    bsps/arm/stm32f4/include/stm32f429xx.h        | 17185
> > > > +++++++++++++
> > > >    bsps/arm/stm32f4/include/stm32f437xx.h        | 17129
> > > > +++++++++++++
> > > >    bsps/arm/stm32f4/include/stm32f439xx.h        | 17479
> > > > +++++++++++++
> > > >    bsps/arm/stm32f4/include/stm32f446xx.h        | 15981
> > > > ++++++++++++
> > > >    bsps/arm/stm32f4/include/stm32f469xx.h        | 20278
> > > > +++++++++++++++
> > > >    bsps/arm/stm32f4/include/stm32f479xx.h        | 20575
> > > > ++++++++++++++++
> > > >    bsps/arm/stm32f4/include/stm32f4xx.h          |   305 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal.h      |   297 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_adc.h  |   898 +
> > > >    .../stm32f4/include/stm32f4xx_hal_adc_ex.h    |   407 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_can.h  |   844 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_cec.h  |   792 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_conf.h |   506 +
> > > >    .../stm32f4/include/stm32f4xx_hal_cortex.h    |   407 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_crc.h  |   181 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_cryp.h |   683 +
> > > >    .../stm32f4/include/stm32f4xx_hal_cryp_ex.h   |   142 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_dac.h  |   480 +
> > > >    .../stm32f4/include/stm32f4xx_hal_dac_ex.h    |   205 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_dcmi.h |   563 +
> > > >    .../stm32f4/include/stm32f4xx_hal_dcmi_ex.h   |   208 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_def.h  |   210 +
> > > >    .../arm/stm32f4/include/stm32f4xx_hal_dfsdm.h |  1141 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_dma.h  |   802 +
> > > >    .../arm/stm32f4/include/stm32f4xx_hal_dma2d.h |   638 +
> > > >    .../stm32f4/include/stm32f4xx_hal_dma_ex.h    |   102 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_dsi.h  |  1377 ++
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_eth.h  |  2144 ++
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_exti.h |   366 +
> > > >    .../arm/stm32f4/include/stm32f4xx_hal_flash.h |   425 +
> > > >    .../stm32f4/include/stm32f4xx_hal_flash_ex.h  |  1063 +
> > > >    .../include/stm32f4xx_hal_flash_ramfunc.h     |    76 +
> > > >    .../stm32f4/include/stm32f4xx_hal_fmpi2c.h    |   837 +
> > > >    .../stm32f4/include/stm32f4xx_hal_fmpi2c_ex.h |   150 +
> > > >    .../stm32f4/include/stm32f4xx_hal_fmpsmbus.h  |   790 +
> > > >    .../include/stm32f4xx_hal_fmpsmbus_ex.h       |   136 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_gpio.h |   325 +
> > > >    .../stm32f4/include/stm32f4xx_hal_gpio_ex.h   |  1590 ++
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_hash.h |   634 +
> > > >    .../stm32f4/include/stm32f4xx_hal_hash_ex.h   |   175 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_hcd.h  |   316 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_i2c.h  |   741 +
> > > >    .../stm32f4/include/stm32f4xx_hal_i2c_ex.h    |   115 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_i2s.h  |   618 +
> > > >    .../stm32f4/include/stm32f4xx_hal_i2s_ex.h    |   183 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_irda.h |   682 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_iwdg.h |   220 +
> > > >    .../arm/stm32f4/include/stm32f4xx_hal_lptim.h |   857 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_ltdc.h |   719 +
> > > >    .../stm32f4/include/stm32f4xx_hal_ltdc_ex.h   |    83 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_mmc.h  |   747 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_nand.h |   388 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_nor.h  |   330 +
> > > >    .../stm32f4/include/stm32f4xx_hal_pccard.h    |   285 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_pcd.h  |   459 +
> > > >    .../stm32f4/include/stm32f4xx_hal_pcd_ex.h    |    88 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_pwr.h  |   427 +
> > > >    .../stm32f4/include/stm32f4xx_hal_pwr_ex.h    |   340 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_qspi.h |   750 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_rcc.h  |  1459 ++
> > > >    .../stm32f4/include/stm32f4xx_hal_rcc_ex.h    |  7111 ++++++
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_rng.h  |   361 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_rtc.h  |   915 +
> > > >    .../stm32f4/include/stm32f4xx_hal_rtc_ex.h    |  1079 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_sai.h  |   895 +
> > > >    .../stm32f4/include/stm32f4xx_hal_sai_ex.h    |   114 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_sd.h   |   758 +
> > > >    .../arm/stm32f4/include/stm32f4xx_hal_sdram.h |   238 +
> > > >    .../stm32f4/include/stm32f4xx_hal_smartcard.h |   755 +
> > > >    .../arm/stm32f4/include/stm32f4xx_hal_smbus.h |   731 +
> > > >    .../stm32f4/include/stm32f4xx_hal_spdifrx.h   |   604 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_spi.h  |   729 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_sram.h |   236 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_tim.h  |  2146 ++
> > > >    .../stm32f4/include/stm32f4xx_hal_tim_ex.h    |   354 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_uart.h |   884 +
> > > >    .../arm/stm32f4/include/stm32f4xx_hal_usart.h |   648 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_hal_wwdg.h |   298 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_ll_adc.h   |  4779 ++++
> > > >    bsps/arm/stm32f4/include/stm32f4xx_ll_bus.h   |  2105 ++
> > > >    .../arm/stm32f4/include/stm32f4xx_ll_cortex.h |   637 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_ll_crc.h   |   201 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_ll_dac.h   |  1455 ++
> > > >    bsps/arm/stm32f4/include/stm32f4xx_ll_dma.h   |  2868 +++
> > > >    bsps/arm/stm32f4/include/stm32f4xx_ll_dma2d.h |  1901 ++
> > > >    bsps/arm/stm32f4/include/stm32f4xx_ll_exti.h  |   954 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_ll_fmc.h   |  1416 ++
> > > >    .../arm/stm32f4/include/stm32f4xx_ll_fmpi2c.h |  2234 ++
> > > >    bsps/arm/stm32f4/include/stm32f4xx_ll_fsmc.h  |  1086 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_ll_gpio.h  |   981 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_ll_i2c.h   |  1890 ++
> > > >    bsps/arm/stm32f4/include/stm32f4xx_ll_iwdg.h  |   302 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_ll_lptim.h |  1378 ++
> > > >    bsps/arm/stm32f4/include/stm32f4xx_ll_pwr.h   |   985 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_ll_rcc.h   |  7096 ++++++
> > > >    bsps/arm/stm32f4/include/stm32f4xx_ll_rng.h   |   335 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_ll_rtc.h   |  3663 +++
> > > >    bsps/arm/stm32f4/include/stm32f4xx_ll_sdmmc.h |  1141 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_ll_spi.h   |  2027 ++
> > > >    .../arm/stm32f4/include/stm32f4xx_ll_system.h |  1711 ++
> > > >    bsps/arm/stm32f4/include/stm32f4xx_ll_tim.h   |  4093 +++
> > > >    bsps/arm/stm32f4/include/stm32f4xx_ll_usart.h |  2521 ++
> > > >    bsps/arm/stm32f4/include/stm32f4xx_ll_usb.h   |   536 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_ll_utils.h |   307 +
> > > >    bsps/arm/stm32f4/include/stm32f4xx_ll_wwdg.h  |   316 +
> > > >    bsps/arm/stm32f4/include/system_stm32f4xx.h   |   104 +
> > > 
> > > You most likely noted the long discussion on Discord between
> > > Andrei
> > > of
> > > the North and me regarding how the hal could be made more
> > > application-friendly. @Andrei: Do you think the headers should be
> > > moved
> > > into a subdirectory to make them simpler to avoid in the
> > > application?
> > > 
> > > >    bsps/arm/stm32f4/start/bspstart.c             |   202 +-
> > > >    bsps/arm/stm32f4/start/bspstart_old.c         |   297 +
> > > >    spec/build/bsps/arm/grp.yml                   |     5 +-
> > > >    spec/build/bsps/arm/stm32f4/grp.yml           |    12 +-
> > > >    spec/build/bsps/arm/stm32f4/obj.yml           |   220 +
> > > >    spec/build/bsps/arm/stm32f4/optenhal.yml      |    16 +
> > > >    spec/build/bsps/arm/stm32f4/opthse.yml        |    17 +
> > > >    spec/build/bsps/arm/stm32f4/optusehse.yml     |    16 +
> > > >    spec/build/bsps/arm/stm32f4/optvariant.yml    |    24 +
> > > >    spec/build/bsps/obj.yml                       |     1 +
> > > 
> > > Did the HAL files compile completely without change? If yes, it
> > > is OK
> > > if
> > > you add them to the yml file right here. Otherwise I would
> > > suggest to
> > > make two to three smaller steps:
> > > 
> > > - Add the unchanged files. Don't add them to the build yet so
> > > that
> > > the
> > > commit would still compile without problems.
> > > - Add necessary changes.
> > > - Add the files to the build.
> > > 
> > > That makes it simpler to find out what you might had to change to
> > > make
> > > the files compile and port the changes to a newer version.
> > > 
> > 
> > The HAL files compile completely without changes. However, in one
> > file
> > (stm32f4xx.h), I included bspopts.h. I can split it into 2 commits.
> 
> Would be great if you could split that.
> 
> Best regards
> 
> Christian
> 
> 


More information about the devel mailing list