-Werror on amd64 BSP makes it to installed package configuration file

[Chris Johns]

On 20/8/2022 6:07 am, Joel Sherrill wrote:
> On Fri, Aug 19, 2022, 3:00 PM Chris Johns <chrisj at rtems.org
> <mailto:chrisj at rtems.org>> wrote:
>     > On 20 Aug 2022, at 3:39 am, Joel Sherrill <joel at rtems.org
>     <mailto:joel at rtems.org>> wrote:
>     >
>     > Hi
>     >
>     > Stephen tripped across this and I'm reporting it because it is going to
>     > take some discussion to resolve.
>     >
>     > Stephen is using the .pc files to create a configuration file
>     > for the FACE Conformance Test Suite. This is now basically working
>     > for multiple BSPs. The amd64 includes -Werror in its BSP compiler
>     > options and is the only BSP to do so.
> 
>     Looks like a bug to me. It should not be in the standard CFLAGS returned by
>     pkgconfig.

> Is there code.on our side filtering flags that missed this? I grep'ed for Werror
> and Wall but didn't find anything.

It should be only including the ABI flags so maybe they are wrong in this BSP:

https://git.rtems.org/rtems/tree/spec/build/bsps/x86_64/amd64/abi.yml

I have no idea why this is here.

>     > (1) Do we want a BSP to include -Werror? amd64 being the only one
>     > and use having a history of chasing warnings after gcc upgrades.
> 
>     Yes remove.
> 
> Ok but is this the only way to remove a warning from the PC file?

The waf code to build generate the file should only include the ABI and include
options.

Chris