[PATCH rtems-docs 0/1] TFTPFS: Add block and window size options

Frank Kuehndel frank.kuehndel at embedded-brains.de
Fri Jun 3 15:22:04 UTC 2022


From: Frank Kühndel <frank.kuehndel at embedded-brains.de>

Hello all,

I extended the TFTP file system to support the block size and the
window size options (RFCs 2347, 2348, 7440).  Essentially, this
significantly improves the download and upload speeds provided the
TFTP server on the other side also supports at least one of these
options.

To implement it I had to substantially change the network related
part of the code.  I also created a test suite for the TFTP code.
Indeed the test suite is by far the largest part.  Moreover, I wrote
a documentation.

This patch set provides the new documentation.  It replaces the
already existing but basically empty chapter "Trivial FTP Client
Filesystem" in the "RTEMS Filesystem Design Guide".  There are also
two image files - an .svg and an .png - which are used in the text.
These are not in this patch set as I believe no one will review SVG
code or binary PNG.  Instead I put the generated PDF (including the
diagram) for download at the link shown below.  I hope the PDF is
more convenient to read than the patch itself.  

https://share.embedded-brains.de/index.php/s/6MkMHkyRLKR2XBp/download/filesystem.pdf

Please, remind that only chapter "Trivial FTP Client Filesystem" in
this PDF is new.

There is one issue with the copyright which is not clear to me.  I
adapted the copyright notice in filesystem/index.rst.  This copyright
notice appears in a box just before chapter "PREFACE".  Yet, there
is a second different copyright notice "1988, 2020 RTEMS Project and
contributors" which appears at the first page of the PDF and at the
bottom of each HTML page.  I do not want to complain about this.  I
just found it a bit inconsistent.

Next I will send the changed code as an own patch set to the mailing
list.

Thanks in advance for your review efforts, any questions and comments.
Note, due to a bank holiday I will response to your emails no earlier
than Tuesday.

Greetings
Frank


Frank Kühndel (1):
  TFTPFS: New documentation

 filesystem/index.rst       |   1 +
 filesystem/trivial_ftp.rst | 638 ++++++++++++++++++++++++++++++++++++-
 2 files changed, 636 insertions(+), 3 deletions(-)

-- 
2.35.3



More information about the devel mailing list