STM32H7 HAL update, merge ready.

[Karel Gardas]

On 3/10/22 14:52, Sebastian Huber wrote:
> On 10/03/2022 14:49, Karel Gardas wrote:
>> On 3/10/22 14:45, Sebastian Huber wrote:
>>> On 10/03/2022 14:41, Karel Gardas wrote:
>>>> On 3/10/22 13:42, Sebastian Huber wrote:
>>>>> On 10/03/2022 13:18, Karel Gardas wrote:
>>>>>>
>>>>>> Hello Sebastian,
>>>>>>
>>>>>> https://github.com/kgardas/rtems/tree/stm32h7-hal-update -- 
>>>>>> contains all required/recommended by you. Please recheck and merge 
>>>>>> if possible.
>>>>>
>>>>> Is there a line ending change in the STM code update patches? Which 
>>>>> line ending have the new files?
>>>>
>>>> New files preserve line endings of original projects which were 
>>>> source for HAL code. That is LF. 
>>>
>>> The original files were from an archive and not a Git repository. 
>>> Should they be converted first to UNIX line endings before they are 
>>> updated?
>>
>> Hold on! You don't need to do anything besides the git merge. All 
>> files needed are there. I already did the HAL code update! All files 
>> are as provided in original projects besides few changes and besides 
>> reapplied patches from the past. At least that was whole point of the 
>> work...
> 
> The problem is that for example
> 
> https://github.com/kgardas/rtems/commit/d45f034fc379bcb8fecdecc1cb44bd851d6c4949 
> 
> 
> changes the line endings from DOS to UNIX AND performs the update. This 
> should be two commits. First the change to UNIX line endings and then 
> the update.

Yes, but the problem was that original files were too chaotic to do 
anything about it -- in fact HAL files were using mixed line endings.

So, the only way out of the chaos was to:

1) replace all HAL files with new files

2) reapply patches done by RTEMS community over HAL files

I did exactly this. So now, you have new HAL + patches on top of that.

The only missing patch which were not merged in is doxygen tag patch 
(IIRC you were the author). But due to HAL changes I've found out it 
would still be incomplete anyway, so I removed it from the process.

Is it a bit more clear now?

Thanks,
Karel