[PATCH 1/1] kern_tc.c: th_generation starts with 1 after overflow for single-core

[Sebastian Huber]

On 27.05.22 10:51, Sebastian Huber wrote:
> Hello Gabriel,
> 
> the uniprocessor version uses an optimization at the reader side:
> 
> #if defined(RTEMS_SMP)
>      } while (gen == 0 || gen != th->th_generation);
> #else
>      } while (gen != th->th_generation);
> #endif
> 
> This is possible since the windup happens with interrupts disabled. I 
> guess you need this optimization somewhere in the PPS/NTP code.
> 
> Could you please add the details to the commit message and not the cover 
> letter. The cover letter is not committed.
> 
> Could you please have a look at:
> 
> https://lists.rtems.org/pipermail/devel/2022-May/071609.html

It would be also good to have a test case for the problem you are trying 
to fix. The PPS/NTP code is a bit complicated and the test coverage of 
this area is far below the score average.

-- 
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.huber at embedded-brains.de
phone: +49-89-18 94 741 - 16
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/