[PATCH v2] spec/pkgconfig: Allow builds to override headers

[Kinsey Moore]

Ping. I'd like to get some kind of commentary on this if only just an "ok"
since I wouldn't feel comfortable committing it without some kind of
acknowledgement. It now takes care of both existing build descriptions
(makefile and pkgconfig). I also have a reversion of the libbsd workaround
ready to go in once this is ok'd. This issue was just hit again on
rtems-lwip.

Kinsey

On Tue, Oct 25, 2022 at 2:03 PM Kinsey Moore <kinsey.moore at oarcorp.com>
wrote:

> This allows any builds targeting an installed RTEMS BSP to override
> headers in the installed BSP reliably, including headers previously
> installed by that or other builds. This includes applications, network
> stacks, libraries, and any other builds.
> ---
>  spec/build/bsps/makecustom.yml | 2 +-
>  spec/build/bsps/pkgconfig.yml  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/spec/build/bsps/makecustom.yml
> b/spec/build/bsps/makecustom.yml
> index 139629b597..9f5f2f2e59 100644
> --- a/spec/build/bsps/makecustom.yml
> +++ b/spec/build/bsps/makecustom.yml
> @@ -2,7 +2,7 @@ SPDX-License-Identifier: CC-BY-SA-4.0 OR BSD-2-Clause
>  build-type: config-file
>  content: |
>    include $$(RTEMS_ROOT)/make/custom/default.cfg
> -  CPU_DEFINES = -I$$(exec_prefix)/$$(RTEMS_BSP)/lib/include
> +  CPU_DEFINES = -isystem$$(exec_prefix)/$$(RTEMS_BSP)/lib/include
>    CPU_CFLAGS = ${ABI_FLAGS}
>    CFLAGS_OPTIMIZE_V = ${OPTIMIZATION_FLAGS}
>    LDFLAGS = -B$$(exec_prefix)/$$(RTEMS_BSP)/lib ${PKGCONFIG_LDFLAGS}
> diff --git a/spec/build/bsps/pkgconfig.yml b/spec/build/bsps/pkgconfig.yml
> index a9462fcc95..8a3c3677a4 100644
> --- a/spec/build/bsps/pkgconfig.yml
> +++ b/spec/build/bsps/pkgconfig.yml
> @@ -22,7 +22,7 @@ content: |
>    Name: ${ARCH}-rtems${__RTEMS_MAJOR__}-${BSP_NAME}
>    Version: ${RTEMS_VERSION}
>    Description: RTEMS BSP ${ARCH}/${BSP_NAME}
> -  Cflags: $${ABI_FLAGS} -I$${includedir}
> +  Cflags: $${ABI_FLAGS} -isystem$${includedir}
>    Ldflags: -B$${libdir} ${PKGCONFIG_LDFLAGS}
>    Libs: -B$${libdir} ${PKGCONFIG_LDFLAGS}
>  copyrights:
> --
> 2.30.2
>
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20221109/767e5d66/attachment.htm>