docs not building to PDF

[Frank Kühndel]

Hello,

I am very sorry for having caused this trouble.

In my first email in June I wrote that there is an image which I did not 
send as part of the patch (who is reviewing some 160KiB binary PNG data 
and will the mailing list server accept that?). Yet, I forgot to mention 
these files in my last Email. I uploaded the two missing files to:

images/filesystem/tftpfs_usage.png:
https://share.embedded-brains.de/index.php/s/fQ4WrLrqmBjcbwC

images/filesystem/ftpfs_usage.svg:
https://share.embedded-brains.de/index.php/s/xk7kArkm6mbjcn2

The SVG file is the source for the PNG. Both files must be placed in the 
images/filesystem folder.

Again sorry for the trouble
Frank


On 10/8/22 22:17, Noor Aman wrote:
> After further digging I found that this image 'tftpfs_usage.png' is
> actually missing from the /images/filesystem directory. So just to confirm
> this, I used a dummy 'tftpfs_usage.png', put that in the same directory and
> everything built fine. So nothing needs to be removed. All we need is the
> actual 'tftpfs_usage.png' image in the directory.
> 
> On Sat, 8 Oct 2022 at 20:00, Joel Sherrill<joel at rtems.org>  wrote:
> 
>>
>> On Sat, Oct 8, 2022 at 7:24 AM Noor Aman<nooraman5718 at gmail.com>  wrote:
>>
>>> Hey Frank,
>>>
>>> I was able to find the issue which was causing the pdf to be not built
>>> properly.
>>> ======
>>> diff --git a/filesystem/trivial_ftp.rst b/filesystem/trivial_ftp.rst
>>> index 3ef8bba..eccd035 100644
>>> --- a/filesystem/trivial_ftp.rst
>>> +++ b/filesystem/trivial_ftp.rst
>>> @@ -280,10 +280,7 @@ application.  The mount point can be any directory.
>>> The name ``/tftp``
>>>   used in the figure serves only as an example.  The final unmounting and
>>>   remove directory steps are optional.
>>>
>>> -.. figure:: ../images/filesystem/tftpfs_usage.png
>>> -  :width: 90%
>>> -  :align: center
>>> -  :alt: TFTP Usage Diagram
>>> +
>>> =======
>>> This png is causing issues. Removing these lines removed the error and
>>> the pdf was generated successfully. I hope this is helpful.
>>>
>> Thanks. I saw this email right as I was setting up to do a git bisect with
>> my
>> morning tea.
>>
>> Two issues with this figure situation.
>>
>> (1) We probably should not have png/jpg files without the corresponding
>> source.
>>
>> (2) I have no idea how to fix this other than to remove the figure. It
>> looks like Frank's
>> text is referencing the figure so simply removing it isn't the best answer.
>>
>> --joel
>>
>>> Thanks,
>>> Noor
>>>
>>> On Sat, 8 Oct 2022 at 05:35, Chris Johns<chrisj at rtems.org>  wrote:
>>>
>>>> On 8/10/2022 9:47 am, Chris Johns wrote:
>>>>> On 8/10/2022 10:12 am, Noor Aman wrote:
>>>>>> I can confirm that the same is happening on my PC too.
>>>>> Could you please bisect the repo to find the patch that broke things?
>>>> A simpler way to find the commit is to see the last build on
>>>> docs.rtems.org
>>>> which is 6.278550b and the next commit after 278550b is:
>>>>
>>>> commit 23fc93bf648507ac417237c20069c4ab7c793251
>>>> Author: Frank Kühndel<frank.kuehndel at embedded-brains.de>
>>>> Date:   Thu Jun 9 15:21:05 2022 +0200
>>>>
>>>>      TFTPFS: New documentation
>>>>
>>>> Frank ?

-- 
embedded brains GmbH
Herr Frank KÜHNDEL
Dornierstr. 4
82178 Puchheim
Germany
email: frank.kuehndel at embedded-brains.de
phone:  +49-89-18 94 741 - 23
mobile: +49-176-15 22 06 - 11
fax:    +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/