docs not building to PDF

[Noor Aman]

After further digging I found that this image 'tftpfs_usage.png' is
actually missing from the /images/filesystem directory. So just to confirm
this, I used a dummy 'tftpfs_usage.png', put that in the same directory and
everything built fine. So nothing needs to be removed. All we need is the
actual 'tftpfs_usage.png' image in the directory.

On Sat, 8 Oct 2022 at 20:00, Joel Sherrill <joel at rtems.org> wrote:

>
>
> On Sat, Oct 8, 2022 at 7:24 AM Noor Aman <nooraman5718 at gmail.com> wrote:
>
>> Hey Frank,
>>
>> I was able to find the issue which was causing the pdf to be not built
>> properly.
>> ======
>> diff --git a/filesystem/trivial_ftp.rst b/filesystem/trivial_ftp.rst
>> index 3ef8bba..eccd035 100644
>> --- a/filesystem/trivial_ftp.rst
>> +++ b/filesystem/trivial_ftp.rst
>> @@ -280,10 +280,7 @@ application.  The mount point can be any directory.
>> The name ``/tftp``
>>  used in the figure serves only as an example.  The final unmounting and
>>  remove directory steps are optional.
>>
>> -.. figure:: ../images/filesystem/tftpfs_usage.png
>> -  :width: 90%
>> -  :align: center
>> -  :alt: TFTP Usage Diagram
>> +
>> =======
>> This png is causing issues. Removing these lines removed the error and
>> the pdf was generated successfully. I hope this is helpful.
>>
>
> Thanks. I saw this email right as I was setting up to do a git bisect with
> my
> morning tea.
>
> Two issues with this figure situation.
>
> (1) We probably should not have png/jpg files without the corresponding
> source.
>
> (2) I have no idea how to fix this other than to remove the figure. It
> looks like Frank's
> text is referencing the figure so simply removing it isn't the best answer.
>
> --joel
>
>>
>> Thanks,
>> Noor
>>
>> On Sat, 8 Oct 2022 at 05:35, Chris Johns <chrisj at rtems.org> wrote:
>>
>>> On 8/10/2022 9:47 am, Chris Johns wrote:
>>> > On 8/10/2022 10:12 am, Noor Aman wrote:
>>> >> I can confirm that the same is happening on my PC too.
>>> >
>>> > Could you please bisect the repo to find the patch that broke things?
>>>
>>> A simpler way to find the commit is to see the last build on
>>> docs.rtems.org
>>> which is 6.278550b and the next commit after 278550b is:
>>>
>>> commit 23fc93bf648507ac417237c20069c4ab7c793251
>>> Author: Frank Kühndel <frank.kuehndel at embedded-brains.de>
>>> Date:   Thu Jun 9 15:21:05 2022 +0200
>>>
>>>     TFTPFS: New documentation
>>>
>>> Frank ?
>>>
>>> Chris
>>> _______________________________________________
>>> devel mailing list
>>> devel at rtems.org
>>> http://lists.rtems.org/mailman/listinfo/devel
>>
>> _______________________________________________
>> devel mailing list
>> devel at rtems.org
>> http://lists.rtems.org/mailman/listinfo/devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20221009/c1d98c1c/attachment.htm>