[rtems-source-builder commit] sb/setbuilder: Correctly create build set tar files

[Christian MAUDERER]

Hello Chris,

thanks for the response.

Am 29.09.22 um 01:40 schrieb Chris Johns:
> On 28/9/2022 11:42 pm, Christian MAUDERER wrote:
>> Hello,
>>
>> with this patch, I don't get a tar for devel/qemu and for the 6/rtems-microblaze
>> anymore. All other 6/rtems-* toolchains work without problems. I haven't tested
>> a lot of the other packages.
>>
>> The bset for microblaze is a bit different from the other ones. But I'm not yet
>> sure what the relevant difference is.
>>
>> @Chris: With your change: What is necessary that a bset can generate a tar archive?
> 
> It could be a bug if the tools builds work, ie 6/rtems-*. Please raise a ticket?

The tool builds work except for the 6/rtems-microblaze.

> 
> I changed the --bset-tar-file option to create a single tarfile of the final
> staged output of a build. There were a few commits to get this right so I assume
> you are testing on the latest?

I used the current master during the tests. I reverted only the single 
"Correctly create build set tar files" commit to check whether it was 
the relevant one. Without this single commit but all others still in 
place the qemu tar file is created.

> 
> Incremental tarfiles based on separate buildsets in a buildset may have worked
> in some cases however there were some basic issues in how it was implemented.
> When you add deployment requirements on top it did not match up well and it was
> confusing. The best solution was to rebase the tarfile against the final staged
> output as that is known to be correct in all cases.

I'm not sure whether I understand that, but that is because I never 
analyzed how the source builder generates the tar files. I'll try to 
read a bit more documentation and sources.

Best regards

Christian

> 
> I have created a https://git.rtems.org/chrisj/rtems-deployment.git repo and in
> it a config test directory
> (https://git.rtems.org/chrisj/rtems-deployment.git/tree/config/test). I will
> look at adding a test to make sure we catch any issues.
> 
> Thanks
> Chris

-- 
--------------------------------------------
embedded brains GmbH
Herr Christian MAUDERER
Dornierstr. 4
82178 Puchheim
Germany
email:  christian.mauderer at embedded-brains.de
phone:  +49-89-18 94 741 - 18
mobile: +49-176-152 206 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/