[PATCH] wscript: Deduplicate installed files

Chris Johns chrisj at rtems.org
Mon Feb 6 02:35:45 UTC 2023


On 4/2/2023 6:11 am, Sebastian Huber wrote:
> On 03.02.23 19:45, Kinsey Moore wrote:
>> This is my first stab at solving this duplicate install problem. I could
>> manually solve the problem by deduplicating the object includes and moving it
>> up to the BSP, but that is less intuitive since these drivers both depend on
>> the same code and the BSP doesn't depend on it directly.
> 
> Why don't you add the shared stuff to a objxilcommon.yml?
> 
> The approach in the wscript is a bit complex from my point of view.

I am OK with adding this code or something similar. It is no more complex than
other places I have reviewed, eg `Item._init_link()`.

The issue is currently not easy to see and may be present in other places
without us knowing. I am also fine with a spec file check that highlights a
clash to draw attention to a problem when the spec files are parsed. I feeling
we need something.

Chris


More information about the devel mailing list