[patch] medit problem

Gedare Bloom gedare at rtems.org
Mon Feb 6 15:12:18 UTC 2023


Hi Zack,

thanks for this patch. Can you please provide a first line of commit
message in line with:
https://docs.rtems.org/branches/master/eng/vc-users.html#commit-message-guidance
Specifically, the first line of your commit should preferably start
with "shell:" or "libmisc/shell:" and if possible briefly summarize
what is fixed "shell: fixes cut-and-paste in main_edit ..."

Gedare

On Sat, Feb 4, 2023 at 1:24 PM zack leung <zakthertemsdev at gmail.com> wrote:
>
> fixes #4557
> ---
>  cpukit/libmisc/shell/main_edit.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/cpukit/libmisc/shell/main_edit.c b/cpukit/libmisc/shell/main_edit.c
> index 191eefa19d..71bb1d931b 100644
> --- a/cpukit/libmisc/shell/main_edit.c
> +++ b/cpukit/libmisc/shell/main_edit.c
> @@ -1710,7 +1710,7 @@ static void copy_selection(struct editor *ed) {
>    ed->env->clipboard = (unsigned char *) realloc(ed->env->clipboard, ed->env->clipsize);
>    if (!ed->env->clipboard) return;
>    copy(ed, ed->env->clipboard, selstart, ed->env->clipsize);
> -  select_toggle(ed);
> +
Avoid adding white space

>  }
>
>  static void cut_selection(struct editor *ed) {
> @@ -2128,7 +2128,7 @@ static void edit(struct editor *ed) {
>
>          case ctrl('e'): select_toggle(ed); break;
>          case ctrl('a'): select_all(ed); break;
> -        case ctrl('c'): copy_selection(ed); break;
> +        case ctrl('c'): copy_selection(ed); select_toggle(ed); break;
>          case ctrl('f'): find_text(ed, 0); break;
>          case ctrl('l'): goto_line(ed); break;
>          case ctrl('g'): find_text(ed, 1); break;
> --
> 2.39.1
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel


More information about the devel mailing list